Skip to content

Remove unused React imports#687

Merged
timja merged 5 commits intojenkinsci:mainfrom
felipecrs:remove-react-import
Apr 30, 2025
Merged

Remove unused React imports#687
timja merged 5 commits intojenkinsci:mainfrom
felipecrs:remove-react-import

Conversation

@felipecrs
Copy link
Contributor

Closes #671

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@felipecrs felipecrs requested a review from a team as a code owner April 29, 2025 15:06
@felipecrs felipecrs marked this pull request as draft April 29, 2025 15:15
@felipecrs felipecrs marked this pull request as ready for review April 29, 2025 15:16
@timja
Copy link
Member

timja commented Apr 29, 2025

This PR is close to done #666

so i'll hold off on merging linting PRs till then

@felipecrs
Copy link
Contributor Author

felipecrs commented Apr 29, 2025

@timja no problem. I can easily rebase it if needed, but this PR is done anyway in case you change your mind.

And it's the last lint-related PR I have in mind.

@felipecrs
Copy link
Contributor Author

Ok, let's wait for #666, I don't want to delay it anyhow.

@felipecrs felipecrs marked this pull request as draft April 29, 2025 16:42
@felipecrs felipecrs marked this pull request as ready for review April 30, 2025 21:47
@felipecrs
Copy link
Contributor Author

@timja this is ready to be reviewed again.

@timja timja added the chore a PR that adds to maintenance - used by Release Drafter label Apr 30, 2025
@timja timja enabled auto-merge (squash) April 30, 2025 21:51
@timja timja merged commit 21d82ce into jenkinsci:main Apr 30, 2025
16 of 17 checks passed
@felipecrs felipecrs deleted the remove-react-import branch April 30, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore a PR that adds to maintenance - used by Release Drafter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unnecessary React import

2 participants