Propagate locale throughout the application#702
Merged
timja merged 1 commit intojenkinsci:mainfrom May 1, 2025
Merged
Conversation
Signed-off-by: lewisbirks <22620804+lewisbirks@users.noreply.github.com>
timja
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new context/provider object for the locale which allows it to be accessed throughout the application given that the component has been wrapped in the provider.
The MultiPipelineGraph component has been updated to make use of this rather than always using en-US as the local for the date which is being displayed. By using the users locale we can render the date in the language/format preferred by that locale.
Fixes #647
Testing done
The multi-pipeline page now has the dates in the users locale, tested in English (UK) and Japanese
English (UK)
Before
After
Japanese
Before
After
Submitter checklist