Skip to content

Optimize interface for mobile#709

Merged
janfaracik merged 6 commits intojenkinsci:mainfrom
janfaracik:optimize-for-mobile
May 2, 2025
Merged

Optimize interface for mobile#709
janfaracik merged 6 commits intojenkinsci:mainfrom
janfaracik:optimize-for-mobile

Conversation

@janfaracik
Copy link
Member

@janfaracik janfaracik commented May 1, 2025

Overrides UI preferences when the viewport width is small (< 700px). Feel the graph is better for mobile users (e.g. larger hitboxes, gesture based, smaller).

Before
image

After
image

Should fix #698

Testing done

  • Resize window and notice UI preferences are overriden
  • In mobile you can no longer show/hide graph/stages

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@janfaracik janfaracik requested a review from a team as a code owner May 1, 2025 21:34
@felipecrs
Copy link
Contributor

@janfaracik you mentioned it should fix #698, but in my case, it was not anyhow mobile, it was a 1080p landscape monitor with certainly more than 700px. Do you still think it can be a fix?

@timja timja added the enhancement New feature or request label May 2, 2025
</li>
{stage.pauseDurationMillis !== 0 && (
<li>
<li className={"jenkins-mobile-hide"}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing to keep in mind here is that nested stages don't show in the graph so its not possible to navigate on mobile then. I wonder if it would be better to move the tree to the top in some way on mobile?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely something to look into I think - still worth getting this in though as currently its a mess on lower resolutions.

@janfaracik
Copy link
Member Author

@janfaracik you mentioned it should fix #698, but in my case, it was not anyhow mobile, it was a 1080p landscape monitor with certainly more than 700px. Do you still think it can be a fix?

Heya, it should. Tried on my MacBook and it's no longer going off the page -

Before
image

After
image

@janfaracik janfaracik merged commit ed95a40 into jenkinsci:main May 2, 2025
17 checks passed
@janfaracik janfaracik deleted the optimize-for-mobile branch May 2, 2025 08:04
@janfaracik janfaracik mentioned this pull request May 2, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New page overflows for big pipelines

3 participants