Skip to content

Don't select first unsuccessful step when the pipeline is running#798

Merged
timja merged 4 commits intojenkinsci:mainfrom
stuartrowe:issue-797
May 31, 2025
Merged

Don't select first unsuccessful step when the pipeline is running#798
timja merged 4 commits intojenkinsci:mainfrom
stuartrowe:issue-797

Conversation

@stuartrowe
Copy link
Contributor

@stuartrowe stuartrowe commented May 30, 2025

Fixes #797.

Added a check if the run was complete when default selecting the first unsuccessful step in a pipeline.

Testing done

TODO - I need to figure out how use playwright to assert that the correct pipeline graph node is selected. Either one has some kind of -active class added to its div / a tag so maybe looking for that on the element with the expected id is the best approach.

NVM - all of the above already exists in the test util class PipelineOverviewPage.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@stuartrowe stuartrowe requested a review from a team as a code owner May 30, 2025 23:34
@felipecrs
Copy link
Contributor

Works great!

chrome_UUXT2k7rUn.mp4

@stuartrowe
Copy link
Contributor Author

I don't have much confidence in the tests as demonstrated by #800 (they pass with and without the fix).

I can reproduce #797 on my own production controller, but not on a local controller started with mvn hpi:run. Perhaps it's good enough that we now have the tests to prevent future regressions.

@timja timja added the bug Something isn't working label May 31, 2025
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timja timja merged commit 3cba824 into jenkinsci:main May 31, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Does not focus running stage if there was an earlier failure

3 participants