Don't select first unsuccessful step when the pipeline is running#798
Merged
timja merged 4 commits intojenkinsci:mainfrom May 31, 2025
Merged
Don't select first unsuccessful step when the pipeline is running#798timja merged 4 commits intojenkinsci:mainfrom
timja merged 4 commits intojenkinsci:mainfrom
Conversation
Contributor
|
Works great! chrome_UUXT2k7rUn.mp4 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #797.
Added a check if the run was complete when default selecting the first unsuccessful step in a pipeline.
Testing done
TODO- I need to figure out how use playwright to assert that the correct pipeline graph node is selected. Either one has some kind of-activeclass added to itsdiv/atag so maybe looking for that on the element with the expectedidis the best approach.NVM - all of the above already exists in the test util class PipelineOverviewPage.
Submitter checklist