Skip to content

Set up VS Code for debugging Java and Frontend#825

Merged
timja merged 6 commits intojenkinsci:mainfrom
felipecrs:vscode
Jun 5, 2025
Merged

Set up VS Code for debugging Java and Frontend#825
timja merged 6 commits intojenkinsci:mainfrom
felipecrs:vscode

Conversation

@felipecrs
Copy link
Contributor

@felipecrs felipecrs commented Jun 5, 2025

Closes #813.

Testing done

Debugging.mp4

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

Open questions

  • Document in CONTRIBUTING.md
  • Can Maven reload Jenkins automatically once bundled files change? Answer
    • I can use nodemon to re-run the Maven process whenever the bundled files change, but Maven takes too long to fully initialize Jenkins, I'm not sure it's worth it.

@felipecrs felipecrs requested a review from a team as a code owner June 5, 2025 01:56
@felipecrs
Copy link
Contributor Author

felipecrs commented Jun 5, 2025

@stuartrowe, @timja, @lewisbirks, what do you think?

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine (untested), definitely don't want maven to re-run on changes. It will live reload anyway for frontend changes like jelly, and some Java changes are hotswappable (compile again without restarting), like changing method bodies

@timja timja added the chore a PR that adds to maintenance - used by Release Drafter label Jun 5, 2025
@felipecrs
Copy link
Contributor Author

Looks fine (untested), definitely don't want maven to re-run on changes. It will live reload anyway for frontend changes like jelly, and some Java changes are hotswappable (compile again without restarting), like changing method bodies

By the way, there must be something wrong in this plugin's Jenkins setup. When pressing Enter to reload, it just throws a bunch of crashes and Jenkins never comes back.

Copy link
Contributor

@lewisbirks lewisbirks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I don't use VS Code but they look right, one minor thing but I'm happy regardless

@lewisbirks
Copy link
Contributor

By the way, there must be something wrong in this plugin's Jenkins setup. When pressing Enter to reload, it just throws a bunch of crashes and Jenkins never comes back.

Yeah, I've never seen that work in this plugin (no experience with others to compare it to)

@timja
Copy link
Member

timja commented Jun 5, 2025

By the way, there must be something wrong in this plugin's Jenkins setup. When pressing Enter to reload, it just throws a bunch of crashes and Jenkins never comes back.

I've never seen it work in any plugin, you don't really want it running in an interactive terminal as its easy for that to happen, I run it intellij where it doesn't trigger.

@lewisbirks
Copy link
Contributor

I'll play around with IntelliJ and see if I can create similar configurations for running (in a separate PR)

```

- Ensure Maven >= 3.9.9 is installed and included in the PATH environment variable.
- Ensure Maven >= 3.9.9 is installed and included in the `PATH` environment variable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we include a maven wrapper 🤔

not one for this PR probably but something to think about @timja

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no strong opinion about it.

@felipecrs
Copy link
Contributor Author

Alright, I have no further changes for this PR. It can be merged whenever you guys feel like.

@timja timja merged commit 4f177e6 into jenkinsci:main Jun 5, 2025
17 checks passed
@felipecrs felipecrs deleted the vscode branch June 5, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore a PR that adds to maintenance - used by Release Drafter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document configuration for debugging React app

3 participants