Skip to content

Stay in Pipeline Overview page when navigating to upstream build #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timja merged 1 commit into from
Jun 6, 2025
Merged

Stay in Pipeline Overview page when navigating to upstream build #829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...in/java/io/jenkins/plugins/pipelinegraphview/cards/items/UpstreamCauseRunDetailsItem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
import hudson.model.Cause;
import hudson.model.CauseAction;
import io.jenkins.plugins.pipelinegraphview.Messages;
import io.jenkins.plugins.pipelinegraphview.PipelineGraphDisplayURLProvider;
import io.jenkins.plugins.pipelinegraphview.cards.RunDetailsItem;
import io.jenkins.plugins.pipelinegraphview.cards.RunDetailsItem.Icon.Ionicon;
import io.jenkins.plugins.pipelinegraphview.cards.RunDetailsItem.ItemContent;
import java.util.List;
import java.util.Objects;
import java.util.Optional;
import org.jenkinsci.plugins.displayurlapi.DisplayURLProvider;
import org.jenkinsci.plugins.workflow.job.WorkflowRun;

public class UpstreamCauseRunDetailsItem {
Expand All @@ -26,7 +26,7 @@ public static Optional<RunDetailsItem> get(WorkflowRun run) {
.map(Cause.UpstreamCause::getUpstreamRun)
.filter(Objects::nonNull)
.map(upstreamRun -> ItemContent.of(
DisplayURLProvider.getDefault().getRunURL(upstreamRun),
new PipelineGraphDisplayURLProvider().getRunURL(upstreamRun),
Messages.cause_upstream(upstreamRun.getDisplayName())))
.<RunDetailsItem>map(
content -> new RunDetailsItem.RunDetail(new Ionicon("play-circle-outline"), content))
Expand Down
3 changes: 2 additions & 1 deletion ...ava/io/jenkins/plugins/pipelinegraphview/cards/items/UpstreamCauseRunDetailsItemTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@ void get() {
RunDetailsItem.RunDetail userDetails = (RunDetailsItem.RunDetail) detailsItem.get();

assertEquals(
new RunDetailsItem.ItemContent.LinkContent(baseUrl + run.getUrl(), Messages.cause_upstream("#1")),
new RunDetailsItem.ItemContent.LinkContent(
baseUrl + run.getUrl() + "pipeline-overview", Messages.cause_upstream("#1")),
userDetails.content());
assertEquals("symbol-play-circle-outline plugin-ionicons-api", userDetails.icon());
}
Expand Down