Skip to content

Fix step header and stage tree not sticking#832

Merged
janfaracik merged 5 commits intojenkinsci:mainfrom
lewisbirks:fix-sticky
Jun 6, 2025
Merged

Fix step header and stage tree not sticking#832
janfaracik merged 5 commits intojenkinsci:mainfrom
lewisbirks:fix-sticky

Conversation

@lewisbirks
Copy link
Contributor

@lewisbirks lewisbirks commented Jun 6, 2025

The --header-height variable doesn't exist in jenkins-core until the baseline targets 2.507.

As such an appropriate value based on the height off the breadcrumbs bar has been used as a fallback

Fixes #739

Testing done

Visual checks manually.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

Signed-off-by: lewisbirks <22620804+lewisbirks@users.noreply.github.com>
Signed-off-by: lewisbirks <22620804+lewisbirks@users.noreply.github.com>
@lewisbirks lewisbirks requested a review from a team as a code owner June 6, 2025 16:18
@lewisbirks
Copy link
Contributor Author

@janfaracik it would be good if you could give it a once over

@janfaracik
Copy link
Member

@janfaracik it would be good if you could give it a once over

Will review in person - see you in a sec.

Signed-off-by: lewisbirks <22620804+lewisbirks@users.noreply.github.com>
Signed-off-by: lewisbirks <22620804+lewisbirks@users.noreply.github.com>
@lewisbirks lewisbirks changed the title fix step header and stage tree not sticking Fix step header and stage tree not sticking Jun 6, 2025
@janfaracik janfaracik added the bugfix A PR that fixes a bug - used by Release Drafter label Jun 6, 2025
@janfaracik janfaracik enabled auto-merge (squash) June 6, 2025 16:51
@janfaracik janfaracik merged commit 1065330 into jenkinsci:main Jun 6, 2025
17 checks passed
@lewisbirks lewisbirks deleted the fix-sticky branch June 7, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix A PR that fixes a bug - used by Release Drafter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pipeline step detail header is not sticky when scrolling the expanded log

2 participants