Merged
Conversation
Signed-off-by: lewisbirks <22620804+lewisbirks@users.noreply.github.com>
Signed-off-by: Lewis Birks <22620804+lewisbirks@users.noreply.github.com>
lewisbirks
commented
Jun 13, 2025
Comment on lines
-405
to
-408
| if (!text) { | ||
| // shouldn't happen | ||
| continue; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
@timja what was the reason for this having to be accounted for?
Member
There was a problem hiding this comment.
umm I think was just a safety thing, if it says shouldn't happen then likely wasn't expected in practice
lewisbirks
commented
Jun 13, 2025
src/main/java/io/jenkins/plugins/pipelinegraphview/utils/AbstractPipelineNode.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lewis Birks <22620804+lewisbirks@users.noreply.github.com>
Signed-off-by: Lewis Birks <22620804+lewisbirks@users.noreply.github.com>
timja
reviewed
Jun 17, 2025
| if (total == null) { | ||
| const interval = setInterval(() => { | ||
| setDuration(sinceStart()); | ||
| }, 3001); // to match step polling interval |
Member
There was a problem hiding this comment.
I increased this in b25d987
As I was noticing while watching live that numbers were going higher than the final result.
Added + 1 so that this starts just after it and is less likely to go over the final result
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each poll currently will cause a re-render even if the stage is still in progress due to the total time changing.
pipeline-graph-view-plugin/src/main/frontend/pipeline-console-view/pipeline-console/main/hooks/use-steps-poller.ts
Lines 159 to 160 in 3cba824
My proposal to address this is to instead return a total time of
nulluntill the run is no longer in progress. In the frontend we can the just kick off a timer which will update every x to ensure that the total increases (essentially faking the data). Oncenullis no longer sent across then it can be replaced with the actual time.TODO:
totalDurationMillisis usedTesting done
Submitter checklist