Redirect to new build on rebuild#854
Merged
timja merged 12 commits intojenkinsci:mainfrom Jun 19, 2025
Merged
Conversation
Signed-off-by: Lewis Birks <22620804+lewisbirks@users.noreply.github.com>
Signed-off-by: Lewis Birks <22620804+lewisbirks@users.noreply.github.com>
lewisbirks
commented
Jun 17, 2025
src/main/java/io/jenkins/plugins/pipelinegraphview/utils/PipelineGraphApi.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lewis Birks <22620804+lewisbirks@users.noreply.github.com>
Signed-off-by: Lewis Birks <22620804+lewisbirks@users.noreply.github.com>
Signed-off-by: Lewis Birks <22620804+lewisbirks@users.noreply.github.com>
Signed-off-by: Lewis Birks <22620804+lewisbirks@users.noreply.github.com>
Signed-off-by: Lewis Birks <22620804+lewisbirks@users.noreply.github.com>
timja
reviewed
Jun 19, 2025
Comment on lines
+409
to
+412
| int offset = ((int) Math.log10(run.getNumber()) + 1) + 1 + URL_NAME.length() + 1 + 9; | ||
| String original = req.getRequestURI(); | ||
| String prefix = original.substring(0, original.length() - offset); | ||
| String url = prefix + nextRun.getNumber() + "/" + URL_NAME + "/"; |
Member
There was a problem hiding this comment.
What is all this?
Can't you just do something like?
nextRun.getUrl() + "/" + URL_NAME + "/"
Signed-off-by: Lewis Birks <22620804+lewisbirks@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #638
It does not appear to be currently possible to display a link in the notification which would be the ideal place to put a link to the scheduled build. Instead we just redirect to the new build once it is available.
The flow is:
Testing done
Manual testing with simple use cases, no delays in launching a build or anything like that.
Submitter checklist