Update duration formatting to use Intl.DurationFormat#857
Merged
timja merged 6 commits intojenkinsci:mainfrom Jun 20, 2025
Merged
Update duration formatting to use Intl.DurationFormat#857timja merged 6 commits intojenkinsci:mainfrom
timja merged 6 commits intojenkinsci:mainfrom
Conversation
Signed-off-by: Lewis Birks <22620804+lewisbirks@users.noreply.github.com>
Signed-off-by: Lewis Birks <22620804+lewisbirks@users.noreply.github.com>
Signed-off-by: Lewis Birks <22620804+lewisbirks@users.noreply.github.com>
Signed-off-by: Lewis Birks <22620804+lewisbirks@users.noreply.github.com>
Signed-off-by: Lewis Birks <22620804+lewisbirks@users.noreply.github.com>
Signed-off-by: Lewis Birks <22620804+lewisbirks@users.noreply.github.com>
timja
reviewed
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #840
Migrate from custom duration formatting messages to those provided by
Intl.DurationFormat.I have tried to keep the consistency in number of digits displayed the same as it was before but if we want this can be altered further.
By using this formatter, it does make the durations generated in the frontend inconsistent with those generated in the backend, see the run detail cards.
I've updated us to node 24 as part of this as the functionality was only introduced in node 23. I have added a polyfill for users that are not on the latest version of their browsers as I expect that it will error out if it runs into that scenario (this shouldn't impact most users, maybe just firefox).
I've had to disable TS checking on the formatter construction as TS does not yet support it.
Testing done
Manual testing with Bulgarian
English for comparison
Submitter checklist