Use custom rendering for input step#866
Conversation
| @@ -0,0 +1,3 @@ | |||
| package io.jenkins.plugins.pipelinegraphview.utils; | |||
|
|
|||
| public record PipelineInputStep(String message, String cancel, String id, String ok, boolean parameters) {} | |||
There was a problem hiding this comment.
jackson with our current config can't serialise the parameters object (if not more) so just map what we need
| <groupId>io.jenkins.tools.bom</groupId> | ||
| <artifactId>bom-${jenkins.baseline}.x</artifactId> | ||
| <version>4136.vca_c3202a_7fd1</version> | ||
| <version>4948.vcf1d17350668</version> |
There was a problem hiding this comment.
version we had in bom had an old version of pipeline-input-step which didn't allow the custom cancel text
| completePercent: number; | ||
| inputStep?: InputStep; | ||
| id: string; | ||
| type: string; |
There was a problem hiding this comment.
What are the values of type? Could it be set to input instead of a new field?
There was a problem hiding this comment.
its STEP, it could be but I need a number of fields anyway
There was a problem hiding this comment.
Yeah, I missed deleting this comment after a further look through the rest of the code
| headers: (window as any).crumb.wrap({}), | ||
| }) | ||
| .then((res) => { | ||
| console.log(res); |
| onClick={ok} | ||
| className={"jenkins-button jenkins-button--primary"} | ||
| > | ||
| {inputStep.ok} |
There was a problem hiding this comment.
I don't know much about the plugin but are there alternatives to just abort/proceed? I feel like I remember in a previous project we had a text input at some point
There was a problem hiding this comment.
Yes those are parameters, the existing behaviour provides a regular link that takes you to the page with parameters. (the one you made prettier recently)
There was a problem hiding this comment.
(we could do the parameters page inline like in blueocean but that's a bigger change and may have the risk of re-renders occurring breaking things when new polls happen)
src/main/frontend/pipeline-console-view/pipeline-console/main/ConsoleLogCard.tsx
Show resolved
Hide resolved
src/main/frontend/pipeline-console-view/pipeline-console/main/ConsoleLine.tsx
Show resolved
Hide resolved
Any thoughts on visually grouping the label/controls? Having both be hoverable feels a bit off to me. |
Updated the confirmation so that its no longer collapsible, happy to add the time/open in new tab links if needed. |
3 participants
Fixes #568
Only thing thats a bit weird is that after approving it shows the built-in ui but not too bad:
Testing done
Manual and automated testing
Parameters (no change):
Input (no args):
Input (modified labels):
Submitter checklist