Improve stability of cancel tests#881
Merged
timja merged 2 commits intojenkinsci:mainfrom Jul 7, 2025
Merged
Conversation
Signed-off-by: Lewis Birks <22620804+lewisbirks@users.noreply.github.com>
timja
reviewed
Jul 7, 2025
| assertTrue(p.getByRole(AriaRole.BUTTON, new Page.GetByRoleOptions().setName("Cancel")) | ||
| .isVisible()); | ||
| Locator cancelLocator = p.getByRole(AriaRole.BUTTON, new Page.GetByRoleOptions().setName("Cancel")); | ||
| assertThat(cancelLocator).isVisible(); |
Member
There was a problem hiding this comment.
There doesn't seem to be any waiting here, (except the one wait for hidden that is removed), could you explain this a bit? the isVisible and isHidden checks you've added won't wait for them to be true as far as I can tell?
Contributor
Author
There was a problem hiding this comment.
From what I remember in the docs, the assertions retry/wait automatically. I'll double check tomorrow though
Member
There was a problem hiding this comment.
Ah, Time to retry the assertion for in milliseconds. Defaults to 5000.
Member
|
Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt to fix jenkinsci/bom#5276. I wasn't able to recreate the issue locally but looking at the output of the ci test results it appears that the code to wait until the cancel button is hidden is executing before the dialog is closed and as such finds two instances of a cancel button on the page (the button in the dialog and the button to show the dialog).
Testing done
Submitter checklist