Skip to content

Reduce number of calls to FlowNode#getEnclosingId #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timja merged 1 commit into from
Jul 8, 2025
Merged

Reduce number of calls to FlowNode#getEnclosingId #883

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/main/java/io/jenkins/plugins/pipelinegraphview/treescanner/NodeRelationshipFinder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,18 +96,19 @@ private void handleBlockStart(@NonNull FlowNode node) {
}

private void addSeenNodes(FlowNode node) {
if (!seenChildNodes.containsKey(node.getEnclosingId())) {
seenChildNodes.put(node.getEnclosingId(), new ArrayDeque<>());
String enclosingId = node.getEnclosingId();
if (!seenChildNodes.containsKey(enclosingId)) {
seenChildNodes.put(enclosingId, new ArrayDeque<>());
}
if (isDebugEnabled) {
logger.debug("Adding {} to seenChildNodes {}", node.getId(), node.getEnclosingId());
logger.debug("Adding {} to seenChildNodes {}", node.getId(), enclosingId);
}
seenChildNodes.get(node.getEnclosingId()).push(node);
seenChildNodes.get(enclosingId).push(node);
}

@CheckForNull
private FlowNode getAfterNode(FlowNode node) {
FlowNode after = null;
FlowNode after;
// The after node is the last child of the enclosing node, except for the last node in
// a block, then it's the last node in the enclosing nodes list (likely, this blocks end node).
FlowNode parentStartNode = getFirstEnclosingNode(node);
Expand Down