Do not reset expanded steps while polling, only extend them#908
Merged
lewisbirks merged 6 commits intojenkinsci:mainfrom Jul 24, 2025
Merged
Do not reset expanded steps while polling, only extend them#908lewisbirks merged 6 commits intojenkinsci:mainfrom
lewisbirks merged 6 commits intojenkinsci:mainfrom
Conversation
Hint: Collapsing a step also marks it as "?selected-node". Previously, any following polling responses would action on the "?selected-node" again and expand the step that was just collapsed. Also, any other steps that were opened in addition to the last "?selected-node" would be collapsed again. When switching stages, all steps would be collapsed again. Now, steps do not get collapsed eagerly.
Contributor
|
I'm finding that if I subsequently close a step, on the next poll it will reopen that step. I don't think this is the intended behaviour |
Contributor
Author
Indeed, this is not intuitive. It is logged as a separate bug: |
Contributor
My bad, forgot to delete this comment after I had seen the other PR |
lewisbirks
approved these changes
Jul 23, 2025
Contributor
lewisbirks
left a comment
There was a problem hiding this comment.
LGTM, thanks for the improvements 🚀
- Reduce polling interval - Remove rerender hack for "run" poller after merging polling changes
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #905
Hint: Collapsing a step also marks it as "?selected-node".
Previously, any following polling responses would action on the "?selected-node" again and expand the step that was just collapsed. Also, any other steps that were opened in addition to the last "?selected-node" would be collapsed again. When switching stages, all steps would be collapsed again.
Now, steps do not get collapsed eagerly.
Testing done
Submitter checklist