Skip to content

Add build description#926

Merged
timja merged 2 commits intojenkinsci:mainfrom
timja:description
Jul 26, 2025
Merged

Add build description#926
timja merged 2 commits intojenkinsci:mainfrom
timja:description

Conversation

@timja
Copy link
Member

@timja timja commented Jul 25, 2025

Fixes #922

@janfaracik / @lewisbirks any thoughts on the UI for this?

Not sure I like the alerts for this.

Testing done

stage('echo') {
    currentBuild.description = "<strong>This is a really cool description</strong>, this is less interesting. <p>A paragraph</p> <br /> dot dot dot..."
    echo "hi"
}

stage('good bye') {
    echo "see ya"
}

With html formatting:

image

Simple:

image
No description (click to expand) image

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@timja timja added the enhancement New feature or request label Jul 25, 2025
@timja
Copy link
Member Author

timja commented Jul 25, 2025

Also looks like there's a 'bug' in alerts where p tags don't have their color overridden so may need to fix that if we use alerts.

@felipecrs
Copy link
Contributor

felipecrs commented Jul 25, 2025

I'm always concerned about use of vertical space, but I got to admit I can't think of a better place for this. It looks nice.

@janfaracik
Copy link
Member

image

How is this? Also agreed on not liking the alert, feels like the wrong use for the component. Can't think of a better icon than (i) - maybe a pencil? Might indicate its editable though...

@lewisbirks
Copy link
Contributor

I think the i is the right choice and yeah pencil to me would indicate editable

@lewisbirks
Copy link
Contributor

Would we want it to be collapsible if it was longer than a line or two?

@janfaracik
Copy link
Member

Would we want it to be collapsible if it was longer than a line or two?

Good shout - not sure how well that would work with like HTML descriptions though?

@timja
Copy link
Member Author

timja commented Jul 26, 2025

Looks good although I think its aligned with the bottom of the icon, looks a little off to me?

image

I think the i is the right choice and yeah pencil to me would indicate editable

TBH they probably should be editable, see the main build page:

image

Would we want it to be collapsible if it was longer than a line or two?

Yeah good idea

@lewisbirks
Copy link
Contributor

Would we want it to be collapsible if it was longer than a line or two?

Good shout - not sure how well that would work with like HTML descriptions though?

This is defo a work in progress and could be down to someone else to style and arrange properly but something like this maybe?

image image

@KalleOlaviNiemitalo
Copy link

Is it necessary to have an icon at all?

@janfaracik
Copy link
Member

Is it necessary to have an icon at all?

It keeps it consistent/aligned with the details above it - so I'd keep it personally.

@timja timja marked this pull request as ready for review July 26, 2025 14:20
@timja timja requested a review from a team as a code owner July 26, 2025 14:20
@timja
Copy link
Member Author

timja commented Jul 26, 2025

Happy to ship and iterate or want to make some more tweaks to it?

@janfaracik
Copy link
Member

Happy to ship and iterate or want to make some more tweaks to it?

Ship it 🚀

@timja timja merged commit 864406f into jenkinsci:main Jul 26, 2025
17 checks passed
@timja timja deleted the description branch July 26, 2025 18:08
@DreamPWJ
Copy link

image The description has a UI bug. There is occlusion when there is a picture, the badge information is not displayed, and there is a lot of blank space on the right. I think this is not an elegant design. Please provide a switch or can hide it @timja

@DreamPWJ
Copy link

image I suggest adding a new column of build descriptions and placing it in the icon position. This way the UI design saves space and is compatible with the previous style width.

@DreamPWJ
Copy link

image The same UI design principle can be used to build the description of this page. Use the graphic space to place the description above in the blank space below.

@felipecrs
Copy link
Contributor

Maybe it could be made an item in the details bar, which can be hovered to display like the changes details. When clicked, it could be redirected to the main build page, where the description can be better seen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display build description on Pipeline Overview page

6 participants