Fix underspecified react hooks and add linting for it#927
Merged
timja merged 5 commits intojenkinsci:mainfrom Jul 29, 2025
Merged
Fix underspecified react hooks and add linting for it#927timja merged 5 commits intojenkinsci:mainfrom
timja merged 5 commits intojenkinsci:mainfrom
Conversation
The only call-site is conditionally adding the button if present.
Stopping typescript from pulling in Node.JS types is a deep rabbit hole.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on the recent frontend changes and upcoming polling changes for logging, I noticed that many react dependencies are underspecified. In many cases we rely on other dependencies to trigger re-runs or depend on frequent re-rendering for behavior.
This PR is addressing all underspecified react hooks and adds linting to enforce them moving forward. Follow up changes will address some of the frequent re-rendering.
I've done some additional code cleanup/dead code removal to simplify the hook changes. LMK if you want me to move these to other PRs. Theses changes are in separate commits.
There are some indentation changes, so this PR is best reviewed with white space changes ignored.
The eslint plugin
eslint-plugin-react-hooksis maintained upstream:Testing done
stageIsSelectedandhasSelectedDescendantchanges)Submitter checklist