Skip to content

Remove --additional-height logic from graph when in the left position#929

Merged
timja merged 1 commit intojenkinsci:mainfrom
das7pad:remove-additional-height
Jul 29, 2025
Merged

Remove --additional-height logic from graph when in the left position#929
timja merged 1 commit intojenkinsci:mainfrom
das7pad:remove-additional-height

Conversation

@das7pad
Copy link
Contributor

@das7pad das7pad commented Jul 27, 2025

Fixes #928

This PR is a potential fix for #928.

I noticed this expensive "scroll" handler and in testing the implications of removing it, it seemed that this is actually fixing a bug. The extra offset may have been required in the past.

Testing done

pipeline {
    agent any

    stages {
        stage('Hello') {
            steps {
                script {
                    for(int i=1; i<=3; i++) {
                        stage("Stage - ${i}") {
                            sh 'for i in `seq 13`; do sleep 0.5; echo "Slept ${i} times"; done'
                        }
                    }
                }
            }
        }
    }
}
  • select "left" position for graph
  • scroll to the bottom
before after
Image Image

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@das7pad das7pad requested a review from a team as a code owner July 27, 2025 21:57
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, tested and could reproduce the issue before and not after

I'll ship it, but @janfaracik you remember if this is needed for anything?

@timja timja added the bug Something isn't working label Jul 29, 2025
@timja timja merged commit bf5d892 into jenkinsci:main Jul 29, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Graph position is off with large console output

2 participants