Remove --additional-height logic from graph when in the left position#929
Merged
timja merged 1 commit intojenkinsci:mainfrom Jul 29, 2025
Merged
Remove --additional-height logic from graph when in the left position#929timja merged 1 commit intojenkinsci:mainfrom
timja merged 1 commit intojenkinsci:mainfrom
Conversation
timja
approved these changes
Jul 29, 2025
Member
There was a problem hiding this comment.
Seems fine, tested and could reproduce the issue before and not after
I'll ship it, but @janfaracik you remember if this is needed for anything?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #928
This PR is a potential fix for #928.
I noticed this expensive "scroll" handler and in testing the implications of removing it, it seemed that this is actually fixing a bug. The extra offset may have been required in the past.
Testing done
pipeline { agent any stages { stage('Hello') { steps { script { for(int i=1; i<=3; i++) { stage("Stage - ${i}") { sh 'for i in `seq 13`; do sleep 0.5; echo "Slept ${i} times"; done' } } } } } } }Submitter checklist