Predictable Snippetizer output for LibraryStep#215
Merged
jglick merged 2 commits intojenkinsci:masterfrom Nov 14, 2025
Merged
Conversation
jglick
commented
Nov 14, 2025
| UninstantiatedDescribable scmUd = (UninstantiatedDescribable) scm; | ||
| Map<String, Object> scmArguments = new HashMap<>(scmUd.getArguments()); | ||
| if (scm instanceof UninstantiatedDescribable scmUd) { | ||
| Map<String, Object> scmArguments = new LinkedHashMap<>(scmUd.getArguments()); |
jglick
commented
Nov 14, 2025
| if (scm instanceof UninstantiatedDescribable) { | ||
| UninstantiatedDescribable scmUd = (UninstantiatedDescribable) scm; | ||
| Map<String, Object> scmArguments = new HashMap<>(scmUd.getArguments()); | ||
| if (scm instanceof UninstantiatedDescribable scmUd) { |
Member
Author
There was a problem hiding this comment.
Java 17 or whatever it is
jglick
commented
Nov 14, 2025
| Map<String, Object> scmArguments = new LinkedHashMap<>(scmUd.getArguments()); | ||
| scmArguments.remove("id"); | ||
| Map<String, Object> retrieverArguments = new HashMap<>(ud.getArguments()); | ||
| Map<String, Object> retrieverArguments = new LinkedHashMap<>(ud.getArguments()); |
jglick
commented
Nov 14, 2025
| // TODO uninstantiate works but SnippetizerTester.assertRoundTrip fails due to differing SCMSource.id values | ||
| assertEquals("library identifier: 'foo@master', retriever: modernSCM(gitSource(traits: [gitBranchDiscovery()], credentialsId: '', remote: 'https://nowhere.net/'))", Snippetizer.object2Groovy(s)); | ||
| // TODO uninstantiate works but SnippetizerTester.assertRoundTrip fails due to differing SCMSource.id values pending https://github.com/jenkinsci/scm-api-plugin/pull/357 | ||
| assertEquals("library identifier: 'foo@master', retriever: modernSCM(gitSource(credentialsId: '', remote: 'https://nowhere.net/', traits: [gitBranchDiscovery()]))", Snippetizer.object2Groovy(s)); |
Member
Author
There was a problem hiding this comment.
Now alphabetized as expected: credentials remote traits
dwnusbaum
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See jenkinsci/structs-plugin#255. Discovered while testing jenkinsci/scm-api-plugin#357.