Migrate tests to JUnit Jupiter #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Migrate annotations and imports * Migrate assertions * Remove public visibility for test classes and methods * Minor code cleanup * Ban JUnit4 imports
| } | ||
|
|
||
| @Override | ||
| @SuppressFBWarnings("EQ_COMPARETO_USE_OBJECT_EQUALS") |
Author
There was a problem hiding this comment.
Build failed otherwise.
| return String.format("quay.io/%s/%s:%s", organization, repository, tag); | ||
| } | ||
|
|
||
| @SuppressFBWarnings("NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE") |
Author
There was a problem hiding this comment.
Build failed otherwise.
| ), | ||
| CredentialsMatchers.withId(credentialsId) | ||
| ); | ||
| CredentialsProvider.lookupCredentialsInItemGroup( |
Author
There was a problem hiding this comment.
Build failed otherwise.
| ), | ||
| CredentialsMatchers.withId(credentialsId) | ||
| ); | ||
| CredentialsProvider.lookupCredentialsInItem( |
Author
There was a problem hiding this comment.
Build failed otherwise.
| ), | ||
| CredentialsMatchers.withId(credentialsId) | ||
| ); | ||
| CredentialsProvider.lookupCredentialsInItem( |
Author
There was a problem hiding this comment.
Build failed otherwise.
| ), | ||
| CredentialsMatchers.withId(credentialsId) | ||
| ); | ||
| CredentialsProvider.lookupCredentialsInItem( |
Author
There was a problem hiding this comment.
Build failed otherwise.
Author
|
Sources had to be formatted with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to migrate all tests to JUnit Jupiter. Changes include:
I am well aware that this is a quite large changeset however I hope that there is still interest in this PR and it will be reviewed.
If there are any questions, please do not hesitate to ping me.
Submitter checklist