Skip to content

[JENKINS-67829] compute the checksum per JVM #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jtnord wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[JENKINS-67829] compute the checksum per JVM #811

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a901cf
[JENKINS-67829] compute the checksum per JVM
jtnord Jul 21, 2025
84ce6e5
[JENKINS-67829] compute the checksum per JVM
jtnord Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 17 additions & 16 deletions src/main/java/hudson/remoting/JarLoaderImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import java.io.IOException;
import java.io.NotSerializableException;
import java.io.OutputStream;
import java.io.UncheckedIOException;
import java.net.URISyntaxException;
import java.net.URL;
import java.util.Collections;
Expand All @@ -25,15 +26,12 @@

private static final Logger LOGGER = Logger.getLogger(JarLoaderImpl.class.getName());

@SuppressFBWarnings(value = "SE_BAD_FIELD", justification = "TODO needs triage")
private final ConcurrentMap<Checksum, URL> knownJars = new ConcurrentHashMap<>();
private static final ConcurrentMap<Checksum, URL> KNOWN_JARS = new ConcurrentHashMap<>();

@SuppressFBWarnings(
value = {"DMI_COLLECTION_OF_URLS", "SE_BAD_FIELD"},
justification = "TODO needs triage")
private final ConcurrentMap<URL, Checksum> checksums = new ConcurrentHashMap<>();
@SuppressFBWarnings(value = "DMI_COLLECTION_OF_URLS", justification = "TODO needs triage")

Check warning on line 31 in src/main/java/hudson/remoting/JarLoaderImpl.java

View check run for this annotation

ci.jenkins.io / Open Tasks Scanner

TODO 

NORMAL:
needs triage")
private static final ConcurrentMap<URL, Checksum> CHECKSUMS = new ConcurrentHashMap<>();

@SuppressFBWarnings(value = "SE_BAD_FIELD", justification = "TODO needs triage")

Check warning on line 34 in src/main/java/hudson/remoting/JarLoaderImpl.java

View check run for this annotation

ci.jenkins.io / Open Tasks Scanner

TODO 

NORMAL:
needs triage")
private final Set<Checksum> presentOnRemote = Collections.synchronizedSet(new HashSet<>());

@Override
Expand All @@ -42,7 +40,7 @@
justification = "This is only used for managing the jar cache as files, not URLs.")
public void writeJarTo(long sum1, long sum2, OutputStream sink) throws IOException, InterruptedException {
Checksum k = new Checksum(sum1, sum2);
URL url = knownJars.get(k);
URL url = KNOWN_JARS.get(k);
if (url == null) {
throw new IOException("Unadvertised jar file " + k);
}
Expand Down Expand Up @@ -93,16 +91,19 @@
* Obtains the checksum for the jar at the specified URL.
*/
public Checksum calcChecksum(URL jar) throws IOException {
Checksum v = checksums.get(jar); // cache hit
if (v != null) {
return v;
try {
return CHECKSUMS.computeIfAbsent(jar, u -> {
try {
Checksum c = Checksum.forURL(u);
KNOWN_JARS.put(c, u);
return c;
} catch (IOException e) {
throw new UncheckedIOException(e);
}
});
} catch (UncheckedIOException e) {
throw e.getCause();
}

v = Checksum.forURL(jar);

knownJars.put(v, jar);
checksums.put(jar, v);
return v;
}

/**
Expand Down
Loading