No need to retry inside connectTcp
#827
Merged
+4
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Vlatombe
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare #675. This is called from
innerRunwhich already has its own retry logic.A TCP agent is used in a Pipeline build as part of an integration test in CloudBees CI which restarts the controller and picks a different host:port after the restart. The shutdown of the original controller naturally causes the agent to disconnect. When it tries to connect again, depending on timing conditions,
JnlpAgentEndpointResolver.resolvemight initially have obtained the old host:port, and thenconnectTcpwill try repeatedly to contact it, failing each time. Eventually it will give up and fall back into the main retry loop ininnerRun, but by that time the resumed build might have given up on the agent reconnecting after a 5m timeout and aborted. At least I do see the 5m timeout, though I do not see any messages frominnerRunafterconnectTcpgives up, so I am not exactly sure what the agent is doing at that point.#771 (comment) remains pending.