fix: correct plugin catalog path resolution in is_valid_plugin (fixes #245)#246
Open
Flamki wants to merge 3 commits intojenkinsci:mainfrom
Open
fix: correct plugin catalog path resolution in is_valid_plugin (fixes #245)#246Flamki wants to merge 3 commits intojenkinsci:mainfrom
Flamki wants to merge 3 commits intojenkinsci:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #245.
Description
is_valid_plugin()was resolvingplugin_names.jsonusingos.path.abspath(__file__)as if it were a directory, which can produce an invalid path and raiseFileNotFoundError.This PR fixes path resolution and adds a regression unit test.
Changes
chatbot-core/api/tools/utils.pytools_dir = os.path.dirname(os.path.abspath(__file__))os.path.normpath(os.path.join(tools_dir, "..", "..", "data", "raw", "plugin_names.json"))chatbot-core/tests/unit/tools/test_utils.pytest_is_valid_plugin_returns_true_for_known_plugintest_is_valid_plugin_returns_false_for_unknown_pluginWhy this is aligned / scoped
Testing done
pytest tests/unit/tools/test_utils.py -q->2 passedpylint api/tools/utils.py tests/unit/tools/test_utils.py->10.00/10Submitter checklist