-
-
Notifications
You must be signed in to change notification settings - Fork 78
fix: preserve API prefix in session Location header (fixes #247) #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Flamki
wants to merge
2
commits into
jenkinsci:main
Choose a base branch
from
Flamki:fix/session-location-header
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,11 @@ | ||
| """Unit Tests for FastAPI routes.""" | ||
|
|
||
| from fastapi import FastAPI | ||
| from fastapi.testclient import TestClient | ||
|
|
||
| from api.routes.chatbot import router | ||
|
|
||
|
|
||
| def test_start_chat(client, mock_init_session): | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Use parametrize if necessary |
||
| """Testing that creating a session returns session ID and location.""" | ||
| mock_init_session.return_value = "test-session-id" | ||
|
|
@@ -11,6 +17,20 @@ def test_start_chat(client, mock_init_session): | |
| assert response.headers["location"] == "/sessions/test-session-id/message" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You should change this line, instead of creating a new test |
||
|
|
||
|
|
||
| def test_start_chat_location_includes_router_prefix(mock_init_session): | ||
| """Location header should include API prefix when router is mounted with one.""" | ||
| mock_init_session.return_value = "test-session-id" | ||
|
|
||
| app = FastAPI() | ||
| app.include_router(router, prefix="/api/chatbot") | ||
| prefixed_client = TestClient(app) | ||
|
|
||
| response = prefixed_client.post("/api/chatbot/sessions") | ||
|
|
||
| assert response.status_code == 201 | ||
| assert response.headers["location"] == "/api/chatbot/sessions/test-session-id/message" | ||
|
|
||
|
|
||
| def test_chatbot_reply_success(client, mock_session_exists, mock_get_chatbot_reply): | ||
| """Testing that sending a valid message in a valid session returns a response.""" | ||
| mock_session_exists.return_value = True | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my mind, I thought Location would be used by UI to navigate the page.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Location
Content-Location may be more appropriate
https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Content-Location