refactor: standardize input and UI icons with lucide-react#267
Open
Yugansh5013 wants to merge 1 commit intojenkinsci:mainfrom
Open
refactor: standardize input and UI icons with lucide-react#267Yugansh5013 wants to merge 1 commit intojenkinsci:mainfrom
Yugansh5013 wants to merge 1 commit intojenkinsci:mainfrom
Conversation
e88a283 to
d2e6efe
Compare
d2e6efe to
f1d90c2
Compare
Contributor
divyansh-cyber
left a comment
There was a problem hiding this comment.
just want to mention my findings
Enter key still sends while loading / when input is empty (frontend/src/components/Input.tsx)
handleKeyDown is calling onSend() on Enter without checking isLoading / canSend, so it can send empty or duplicate messages.
Probably better to just guard it with if (isLoading || !canSend) return;
a additional suggestion
File icon placement (frontend/src/components/Input.tsx)
The icon is inside an ellipsis-clipped filename span, so it can get clipped with long names.
Might be better to render it as a sibling element outside the clipped text.
and what i want to ask at last
Is the scope limited to the Input component only?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses UI/UX inconsistencies in the chatbot's
Inputcomponent, specifically focusing on dark mode compatibility and visual alignment with the rest of the plugin.Previously, the input area and file attachment chips relied on hardcoded emojis (📎, 🖼️, 📄) and hardcoded hex colors (
#fff,#ccc,#f8f9fa). These hardcoded values did not respect Jenkins' built-in theming, causing the input area to be glaringly bright and illegible in dark mode.Key Changes:
lucide-reacticons (Paperclip,Image,File,Send, andCircleStopfor the cancel action).chatbotStylesto replace static hex colors with standard Jenkins CSS variables (e.g.,var(--button-background),var(--text-color),var(--panel-background)).UI Changes (Screenshots)
Before (Hardcoded Emojis & Colors)

Light mode:
Dark mode:

After (Lucide Icons & CSS Variables)

Light mode:
Dark mode:

Testing done
Inputbackground, text colors, and newly added Lucide icons dynamically update to match the active theme.ImageandFilelucide icons works correctly in the attachment chips. Verified that theSendandCircleStopicons render correctly based on the message loading state.Submitter checklist