security: avoid raw uploaded filename leakage in service logs (fixes #273)#274
Open
Flamki wants to merge 1 commit intojenkinsci:mainfrom
Open
security: avoid raw uploaded filename leakage in service logs (fixes #273)#274Flamki wants to merge 1 commit intojenkinsci:mainfrom
Flamki wants to merge 1 commit intojenkinsci:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #273.
This PR hardens
file_servicelogging to avoid raw uploaded filename leakage in service logs, while preserving operational signal.What changed
chatbot-core/api/services/file_service.py_safe_filename_for_log()using existingsanitize_logsutility.Processing uploaded file: <filename>with metadata-only logging:chatbot-core/tests/unit/services/test_file_service.pyWhy
Filenames are user-controlled input and can contain sensitive identifiers. This keeps INFO/WARN logs safer by default without changing file-processing behavior or response contracts.
Scope / non-overlap
Verification
pytest tests/unit/services/test_file_service.py -q-> 46 passedpylint api/services/file_service.py tests/unit/services/test_file_service.py-> 10.00/10