tests: add unit tests for rag/embedding/bm25_indexer.py#291
Open
jaishree-verma wants to merge 2 commits intojenkinsci:mainfrom
Open
tests: add unit tests for rag/embedding/bm25_indexer.py#291jaishree-verma wants to merge 2 commits intojenkinsci:mainfrom
jaishree-verma wants to merge 2 commits intojenkinsci:mainfrom
Conversation
- Add tests for _min_max_normalize (empty, equal values, normal range) - Add tests for get_inverted_scores (negative scores, invalid weight, empty input) - Add tests for validate_tool_calls (valid, invalid tool, missing param, wrong type) - Add tests for get_default_tools_call (4 tools, correct names, query passed) - Add tests for filter_retrieved_data (match, no match, case insensitive) - Add tests for extract_chunks_content (combined text, fallback, placeholders) - Add tests for make_placeholder_replacer (returns code, missing code fallback) Closes jenkinsci#211
- Add tests for BM25Indexer.__init__ (stores configs, logger, empty configs) - Add tests for build() (stores retriever, skips None, multiple configs, empty) - Add tests for _index_config() (None when unavailable, error handling, success) - Add tests for get() (None when unavailable, cached retriever, loads from disk, returns None on failure, caches after loading) Closes jenkinsci#290
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
rag/embedding/bm25_indexer.pycontains theBM25Indexerclass which is a critical component of the sparse retrieval pipeline.It currently has zero unit tests as noted in issue #290.
Changes:
Added
tests/unit/rag/embedding/test_bm25_indexer.pycovering all major behaviors:__init__— stores configs, logger, empty configsbuild()— stores retriever for valid config, skips None results,handles multiple configs, handles empty config list
_index_config()— returns None when SparseRetriever unavailable,handles indexing errors gracefully, returns retriever on success
get()— returns None when SparseRetriever unavailable, returnscached retriever, loads from disk when not cached, returns None
on load failure with warning logged, caches after loading
Testing: 13-unit tests covering all methods and edge cases.
Closes #290