feat: added GET /sessions endpoint with pagination#295
Closed
hk2166 wants to merge 2 commits intojenkinsci:mainfrom
Closed
feat: added GET /sessions endpoint with pagination#295hk2166 wants to merge 2 commits intojenkinsci:mainfrom
hk2166 wants to merge 2 commits intojenkinsci:mainfrom
Conversation
hk2166
commented
Mar 17, 2026
Author
hk2166
left a comment
There was a problem hiding this comment.
Adds unit tests for BM25Indexer in rag/embedding/bm25_indexer.py which had zero test coverage. Closes #290
Testing done
12 unit tests added, all passing (pytest tests/unit/rag/embedding/test_bm25_indexer.py -v — 12 passed in 0.02s), covering build(), _index_config(), and get() across both available and unavailable SparseRetriever scenarios.
Submitter checklist
- Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
- Ensure that the pull request title represents the desired changelog entry
- Please describe what you did
- Link to relevant issues in GitHub or Jira — Closes #290
- Link to relevant pull requests, esp. upstream and downstream changes — N/A
- Ensure you have provided tests that demonstrate the feature works or the issue is fixed
Contributor
|
Duplicates. |
Contributor
Contributor
|
Before submitting please look at the openned PR and give feedback in that PR. This PR looks like combining two issues, it makes harder to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
GET /sessionsto list all active server-side sessions with basicmetadata (session ID, message count, last accessed timestamp) and pagination support.
Fixes #218. Complements #196 (GET message history) — together they allow complete
session recovery after a browser restart or sessionStorage clear.
Changes:
lock acquisition to ensure a consistent snapshot of total count and session metadata
GET /sessionswith page (default 1) andpage_size (default 20, clamped to 1–100) query parameters
Testing done
Automated tests were added at both unit and integration level. All 33 tests pass:
Submitter checklist