feat(sanitizer): add redaction for multiple secret types#297
Open
vatsaljain568 wants to merge 1 commit intojenkinsci:mainfrom
Open
feat(sanitizer): add redaction for multiple secret types#297vatsaljain568 wants to merge 1 commit intojenkinsci:mainfrom
vatsaljain568 wants to merge 1 commit intojenkinsci:mainfrom
Conversation
Signed-off-by: Vatsal Jain <jain.vatsal2006@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes two small updates to improve our test suite:
Added missing unit tests in
test_sanitizer.pyto verify thatsanitize_logscorrectly redacts Bearer tokens, GitHub tokens, and RSA private keys.Fixed a failing test in
test_file_upload.py(test_chatbot_reply_upload_empty_message_with_files). The endpoint validation now rejects empty messages with a 422, so I updated the test payload to pass a"dummy message"instead of an empty string to fix the build.Testing done
python3 -m pytestlocally. All unit tests now pass.Submitter checklist