-
-
Notifications
You must be signed in to change notification settings - Fork 42
feat: add docker compose setup for Containerize #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
berviantoleo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look at some comments above.
|
Sorry. One more request. Please update the docs, so the next developer know/understand how to use it. In addition, please have a look at failed CIs. |
berviantoleo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the docs file as described in the PR descriptions.
Sorry, I forgot to mention that I’ll update tomorrow because my end-semester exams are going on. |
No hurry, take your time to understand, and provide with the quality pr |
|
Could you please have a look at the failed CIs? |
|
Hi @berviantoleo, I think the tests aren’t failing because of my PR. Only ESLint is failing due to my changes; the other failures are coming from recent changes in the main branch. |
|
These error from your changes of the config. |
|
Backend test error due to removing pytest from requirements. Hence, should adjust the CI. |
|
@berviantoleo I'll update it by tomorrow |
|
@berviantoleo @cnu1812 Sorry for the delayed response due to my end-semester exams. I’ll be free by the 12th. Kindly approve the workflow to run. I expect the frontend checks to pass now. |
We still have two issues now.
|
|
@berviantoleo Just a thought Would it help if some CI checks (backend, frontend, ESLint) ran automatically without approval, like in other orgs? It might make things easier for contributors. |
|
@saurabhraghuvanshii that may be too big of an ask |
Hi, @saurabhraghuvanshii, |
|
Hey @saurabhraghuvanshii, thanks for pushing through 22 commits on this. The Docker setup works locally and the architecture is solid—just need to fix a few blockers before we can merge. Blocking Issues1. Python version mismatch - 2. Missing 3. Health checks hit 4. No model validation on startup 5. Race condition on startup - Both compose files Recommended Before Merge6. No production compose file 7. Volume strategy breaks in cloud 8. Missing security headers - 9. TypeScript 10. GPU Dockerfile untested Can Be Follow-up PR
Next StepsFix items 1-5 first (about 1 hour), then we can discuss whether to include 6-10 or do them as follow-up. Items 1-3 will cause production failures, so those are hard blockers. Let me know if you want to pair on the health check endpoint or have questions about the production setup. cc: @berviantoleo |
|
@berviantoleo @GunaPalanivel thanks, I'll update pr with all the on 16/01/26 I'm not feeling well. Thanks |
|
@berviantoleo @cnu1812 All tests are passing I double checked |
fixes: #75
[Backend] Containerize the Full Stack (Docker Compose)
Summary
This PR introduces full-stack containerization using Docker Compose, enabling a consistent, reproducible, and production-aligned local and deployment setup. The backend, supporting services, and reverse proxy are containerized with clear separation of concerns, persistent storage, and secure defaults.
Changes
New Files
docker-compose.yml— Orchestrates all servicesbackend/Dockerfile— Backend service containernginx/Dockerfile— Nginx reverse proxy containernginx/nginx.conf— API proxying and routing configuration.dockerignore— Optimized Docker build contextKey Features
Build Dependencies
Resolved common Docker build issues:
These changes ensure deterministic and reliable builds across environments.
Usage
Quick Start
Submitter checklist