-
-
Notifications
You must be signed in to change notification settings - Fork 114
Add a utility method parseAsTreeMap in NamedPathPruner #630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gbhat618
wants to merge
1
commit into
jenkinsci:master
Choose a base branch
from
gbhat618:expose-tree-from-NamedPathPruner
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -211,4 +211,44 @@ private NamedPathPruner(Tree tree) { | |
| public @Override Range getRange() { | ||
| return tree.range; | ||
| } | ||
|
|
||
| /** | ||
| * Parses the given specification and returns a hierarchical tree representation. | ||
| * <p> | ||
| * Each node is represented as a key-value pair in the returned {@code TreeMap}. | ||
| * The value for a key: | ||
| * <ul> | ||
| * <li>Is another {@code TreeMap<String, Object>} for non-leaf nodes.</li> | ||
| * <li>Is an empty {@code TreeMap<String, Object>} for leaf nodes.</li> | ||
| * </ul> | ||
| * | ||
| * @param spec the textual specification | ||
| * @return a hierarchical tree represented as {@code TreeMap<String, Object>}. | ||
| */ | ||
| public static TreeMap<String, Object> parseAsTreeMap(String spec) { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a reason this cannot just be typed as a |
||
| Tree root = parse(spec); | ||
| return toTreeMapRepresentation(root); | ||
| } | ||
|
|
||
| /** | ||
| * Recursively converts the internal {@code Tree} structure into a {@code TreeMap<String, Object>}. | ||
| * <p> | ||
| * Leaf nodes are represented by an empty {@code TreeMap} (e.g., {@code new TreeMap<String, Object>()}). | ||
| * | ||
| * @param tree the internal {@code Tree} structure to convert | ||
| * @return a {@code TreeMap<String, Object>} representing the tree | ||
| */ | ||
| private static TreeMap<String, Object> toTreeMapRepresentation(Tree tree) { | ||
| TreeMap<String, Object> result = new TreeMap<>(); | ||
|
|
||
| for (Map.Entry<String, Tree> entry : tree.children.entrySet()) { | ||
| String key = entry.getKey(); | ||
| Tree childTree = entry.getValue(); | ||
| TreeMap<String, ?> subtree = | ||
| childTree.children.isEmpty() ? new TreeMap<>() : toTreeMapRepresentation(childTree); | ||
| result.put(key, subtree); | ||
| } | ||
|
|
||
| return result; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This requires the caller to cast, and even worse to use unchecked conversions. I think it would be better to expose
Treeor someinterfaceit implements.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minimally
might work