You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I expect time-based expiration to be problematic (#663 (comment)) so this instead allows releasing bound objects when navigating away from the page that registered the proxies.
Pros: Proxies continue to exist until you leave the page.
Cons: Browser involvement needed, a page can accumulate proxies in badly-written code. Probably more.
The current implementation sends one request per proxy, could be collapsed to just one if this approach is deemed preferable.
I wonder if it would not be better to just deprecate l:renderOnDemand, and all uses of BoundObjectTable other than ProgressiveRendering which already has its own logic for releasing the object when the user navigates away from the page (currently done on the server side simply by checking whether a request has been received recently). The usual uses of l:renderOnDemand are to lazily render config form snippets, for newly instantiated objects, but these could be done more efficiently by creating an l:ajax page tied to the Descriptor since its contents are not sensitive to context. (Just need to make sure it is not used in case where there is already an instance—normally these are rendered eagerly; and to honor DescriptorByNameOwner when constructing URLs, to ensure compatibility with the CloudBees CI Templates plugin.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimental alternative to #663.
I expect time-based expiration to be problematic (#663 (comment)) so this instead allows releasing bound objects when navigating away from the page that registered the proxies.
Pros: Proxies continue to exist until you leave the page.
Cons: Browser involvement needed, a page can accumulate proxies in badly-written code. Probably more.
The current implementation sends one request per proxy, could be collapsed to just one if this approach is deemed preferable.
Testing done
With jenkinsci/jenkins#10631:
t:artifactListlazily jenkins#10623 (comment): EmptySubmitter checklist