Skip to content

[FIXED JENKINS-22568] Subversion polling does not work with parameters.#89

Merged
stephenc merged 3 commits intojenkinsci:masterfrom
christ66:JENKINS-22568
Jul 15, 2014
Merged

[FIXED JENKINS-22568] Subversion polling does not work with parameters.#89
stephenc merged 3 commits intojenkinsci:masterfrom
christ66:JENKINS-22568

Conversation

@christ66
Copy link
Member

@christ66 christ66 commented Jul 2, 2014

Currently subversion polling does not work with parameters. This code changes polls using the DEFAULT option. If there is a choice parameter, it will choose the FIRST option. This will also expand anything that is $VAL or ${VAL}.

@cloudbees-pull-request-builder

plugins » subversion-plugin #384 SUCCESS
This pull request looks good

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@oleg-nenashev
Copy link
Member

It could be useful to have an API plugin for variables resolution.
For example, MacroStringHelper from /jenkinsci/perforce-plugin#54 , provides the extensive variables substitution.

I can split the resolver into a separate API plugin if somebody wants to use it

@christ66
Copy link
Member Author

christ66 commented Jul 2, 2014

That doesn't sound like a bad idea. I bet a lot of SCM builders or others would like to use an API like this.

@cloudbees-pull-request-builder

plugins » subversion-plugin #386 SUCCESS
This pull request looks good

stephenc added a commit that referenced this pull request Jul 15, 2014
[FIXED JENKINS-22568] Subversion polling does not work with parameters.
@stephenc stephenc merged commit 396837b into jenkinsci:master Jul 15, 2014
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sure there is a utility in Jenkins core to do macro expansion which you should be using.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christ66 could probably do that... but IIRC the correct utility is actually in a plugin because there are multiple ways to expand tokens or something... anywho I'll leave it up to @christ66 how he wants to respond

@smruti-sahoo
Copy link

smruti-sahoo commented May 4, 2016

Hi - I'm facing the same issue with git poll SCM
Global environment variable are not being picked up during poll SCM

Could someone please help me to solve this issue ?

I tested it on
Jenkins 1.6 and 2.1(Recent version)
git 2.4.2 and 2.4.4 (Recent version)

@recena
Copy link
Contributor

recena commented May 4, 2016

@smruti-sahoo Please, fill a Jira issue with a step by step to reproduce the bug.

@smruti-sahoo
Copy link

@recena Thanks - I've raised JENKINS-34603
I found a similar issue raised around a year before JENKINS-26315 but no update there, hence raised a new one

@christ66 christ66 deleted the JENKINS-22568 branch May 4, 2016 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants