Add support for retrying a build after a node restart by akash-manna-sky · Pull Request #3271 · jenkinsci/warnings-ng-plugin

akash-manna-sky · 2026-02-13T05:42:33Z

When Jenkins retries a build after a restart there might be already a published action available. In such a case we should not fail the build, we should only log a warning.

Fixes #3138

Testing done

Submitter checklist

Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Ensure that the pull request title represents the desired changelog entry
Please describe what you did
Link to relevant issues in GitHub or Jira
Link to relevant pull requests, esp. upstream and downstream changes
Ensure you have provided tests that demonstrate the feature works or the issue is fixed

…ady used by another action: io.jenkins.plugins.analysis.core.model.ResultAction for SpotBugs

akash-manna-sky · 2026-02-20T12:33:44Z

Please review the changes @uhafner

github-actions · 2026-04-12T09:21:50Z

☀️ Quality Monitor

Tests

   Unit Tests: ✅ successful — 93 passed, 2 skipped
   🚀 Integration Tests: ✅ successful — 507 passed, 10 skipped
   ⛔ Architecture Tests: ✅ successful — 15 passed

Coverage for New Code

〰️ Line Coverage: 100.00% — perfect 🎉
➰ Branch Coverage: 100.00% — perfect 🎉

Coverage for Whole Project

〰️ Line Coverage: 80.78% — 1176 missed lines
➰ Branch Coverage: 64.76% — 468 missed branches

Style

   CheckStyle: No warnings
   PMD: No warnings
   ☕ Java Compiler: 97 warnings — normal: 97

Bugs

SpotBugs: No bugs
🐛 Error Prone: 9 bugs — normal: 9

Vulnerabilities

🛡️ OWASP Dependency Check: 214 vulnerabilities — error: 18, high: 54, normal: 136, low: 6

Software Metrics

   🌀 Cyclomatic Complexity: 2603 (total)
   💭 Cognitive Complexity: 835 (total)
   ➿ N-Path Complexity: 2954 (total)
   📏 Lines of Code: 31810 (total)
   📝 Non Commenting Source Statements: 10586 (total)
   🔗 Class Cohesion: 100.00% (maximum)
   ⚖️ Weight of Class: 100.00% (maximum)

🚦 Quality Gates

Overall Status: ❌ FAILURE

✅ Passed Gates

✅ Overall Tests Success Rate: 100.00 >= 100.00
✅ Line Coverage in New Code: 100.00 >= 90.00
✅ Branch Coverage in New Code: 100.00 >= 90.00

❌ Failed Gates

❌ Potential Bugs in Whole Project: 9.00 <= 0.00
❌ Style Violation in Whole Project: 97.00 <= 0.00

Created by Quality Monitor v4.10.0 (#be1b382). More details are shown in the GitHub Checks Result.

uhafner

Can you attach the action with run.addOrReplaceAction

uhafner · 2026-04-16T07:11:04Z

        if (other.isPresent()) {
-            throw new IllegalStateException(
-                    "ID %s is already used by another action: %s%n".formatted(getId(), other.get()));
+            report.logInfo("Removing existing result action with ID '%s' (might be caused by a restart)", getId());


Suggested change

report.logInfo("Removing existing result action with ID '%s' (might be caused by a restart)", getId());

report.logError("Removing existing result action with ID '%s' (duplicate ID: restart or configuration error?)", getId());

Can you remove this method? It makes no sense anymore. Create the selector inline where it is needed.

See line 127.

uhafner · 2026-04-16T07:13:45Z

+        List<AnalysisResult> results = getAnalysisResults(build);
+
+        assertThat(results).hasSize(1);
+        var result = results.get(0);


Can you check the content of the warnings, so we can see that the second result is used? (Or remove one warning from the second file, then check for 5 issues.)

uhafner · 2026-04-16T07:17:34Z

+    /**
+     * Tests retry after restart scenario (JENKINS-72920). When the same tool is run twice within a build
+     * (which can happen during retry after infrastructure failure), the second run should replace the first
+     * with a warning message instead of throwing an exception.
+     */
+    @Test
+    @org.junitpioneer.jupiter.Issue("JENKINS-72920")
+    void shouldAllowRetryAfterRestart() {
+        var project = createFreestyleJob("checkstyle.xml");
+        var tool = createTool(new CheckStyle(), "**/checkstyle-issues.txt");
+        enableWarnings(project, recorder -> recorder.setAggregatingResults(false), tool, tool);
+
+        Run<?, ?> build = buildWithResult(project, Result.SUCCESS);
+
+        List<AnalysisResult> results = getAnalysisResults(build);
+        assertThat(results).hasSize(1);
+
+        var result = results.get(0);
+        assertThat(result).hasId(CHECKSTYLE);
+        assertThat(result).hasTotalSize(6);
+        assertThat(getConsoleLog(result)).contains("Removing existing result action with ID 'checkstyle' (might be caused by a restart)");
+    }
+


This is the same test as shouldThrowExceptionIfSameToolIsConfiguredTwice. Remove it.

uhafner · 2026-04-16T07:18:04Z

+     * be replaced with a warning (to support retry after restart scenarios).
     */
    @Test
    void shouldThrowExceptionIfSameToolIsConfiguredTwice() {


Suggested change

void shouldThrowExceptionIfSameToolIsConfiguredTwice() {

void shouldReplaceExistingAction() {

…e tests for CheckStyle tool behavior

…isting actions

akash-manna-sky · 2026-04-16T18:31:13Z

Can you please review the changes? @uhafner

uhafner

Thanks!

Retry after restart causes IllegalStateException: ID spotbugs is alre…

4430ac6

…ady used by another action: io.jenkins.plugins.analysis.core.model.ResultAction for SpotBugs

akash-manna-sky marked this pull request as ready for review February 13, 2026 19:25

Merge branch 'main' into JENKINS-72920

bc48c23

github-actions bot requested a review from uhafner April 12, 2026 08:59

uhafner requested changes Apr 16, 2026

View reviewed changes

uhafner added the bug Bugs or performance problems label Apr 16, 2026

Refactor IssuesPublisher to handle duplicate result actions and updat…

43b9fdc

…e tests for CheckStyle tool behavior

github-actions bot requested a review from uhafner April 16, 2026 10:55

akash-manna-sky added 3 commits April 16, 2026 17:03

Merge branch 'main' into JENKINS-72920

9536784

Enhance IssuesPublisher to conditionally add ResultAction based on ex…

7ecbc88

…isting actions

Fix one incorrect indentation

e540084

uhafner approved these changes Apr 16, 2026

View reviewed changes

Comment thread plugin/src/main/java/io/jenkins/plugins/analysis/core/steps/IssuesPublisher.java Outdated

Remove redundant call

ca91e3b

github-actions bot requested a review from uhafner April 16, 2026 20:27

uhafner changed the title ~~Retry after restart causes IllegalStateException: ID spotbugs is already used by another action: io.jenkins.plugins.analysis.core.model.ResultAction for SpotBugs~~ Add support for retrying a build after a node restart Apr 17, 2026

uhafner merged commit 94ad6ca into jenkinsci:main Apr 17, 2026
45 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for retrying a build after a node restart #3271

Add support for retrying a build after a node restart #3271
uhafner merged 7 commits intojenkinsci:mainfrom
akash-manna-sky:JENKINS-72920

akash-manna-sky commented Feb 13, 2026 •

edited by uhafner

Loading

Uh oh!

akash-manna-sky commented Feb 20, 2026

Uh oh!

github-actions bot commented Apr 12, 2026

Uh oh!

uhafner left a comment

Uh oh!

uhafner Apr 16, 2026

Uh oh!

uhafner Apr 16, 2026 •

edited

Loading

Uh oh!

uhafner Apr 16, 2026

Uh oh!

uhafner Apr 16, 2026

Uh oh!

uhafner Apr 16, 2026

Uh oh!

akash-manna-sky commented Apr 16, 2026

Uh oh!

uhafner left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	report.logInfo("Removing existing result action with ID '%s' (might be caused by a restart)", getId());
	report.logError("Removing existing result action with ID '%s' (duplicate ID: restart or configuration error?)", getId());

	void shouldThrowExceptionIfSameToolIsConfiguredTwice() {
	void shouldReplaceExistingAction() {

Conversation

akash-manna-sky commented Feb 13, 2026 • edited by uhafner Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing done

Submitter checklist

Uh oh!

akash-manna-sky commented Feb 20, 2026

Uh oh!

github-actions bot commented Apr 12, 2026

☀️ Quality Monitor

Tests

Coverage for New Code

Coverage for Whole Project

Style

Bugs

Vulnerabilities

Software Metrics

🚦 Quality Gates

Overall Status: ❌ FAILURE

✅ Passed Gates

❌ Failed Gates

Uh oh!

uhafner left a comment

Choose a reason for hiding this comment

Uh oh!

uhafner Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

uhafner Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

uhafner Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

uhafner Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

uhafner Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

akash-manna-sky commented Apr 16, 2026

Uh oh!

uhafner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

akash-manna-sky commented Feb 13, 2026 •

edited by uhafner

Loading

uhafner Apr 16, 2026 •

edited

Loading