Skip to content

Await LanguageClient start during VSCode extension activation - #50

Draft
jennings with Copilot wants to merge 1 commit into
mainfrom
copilot/investigate-vscode-e2e-tests-failures
Draft

Await LanguageClient start during VSCode extension activation#50
jennings with Copilot wants to merge 1 commit into
mainfrom
copilot/investigate-vscode-e2e-tests-failures

Conversation

Copilot AI commented Jun 4, 2026

Copy link
Copy Markdown

VSCode e2e tests were failing in CI with "Client is not running" errors. This race condition occurred because the extension activation hook was returning before the LanguageClient finished initializing, allowing test commands to fire before the server was ready.

Extension Activation

  • Added await to client.start() to block the activate resolution until the LSP client is fully initialized.
  client = new LanguageClient(
    "badjuju",
    "Bad Juju",
    serverOptions,
    clientOptions,
  );
- client.start();
+ await client.start();

Copilot AI changed the title Fix VSCode e2e tests failing with "Client is not running" Await LanguageClient start during VSCode extension activation Jun 4, 2026
Copilot AI requested a review from jennings June 4, 2026 03:58
Copilot stopped work on behalf of jennings due to an error June 4, 2026 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants