fix: stop centering the viewport on mouse line clicks in diffs - #384
Merged
Conversation
Every line click re-centered the focused line, breaking double-click word selection because the first click moved the content under the cursor. Focus changes now carry their source; only keyboard and programmatic focus keep the centering scroll, while mouse clicks never move the viewport. The inline comment form now scrolls itself fully into view on open with the smallest possible scroll, so clicking a line near the viewport bottom still shows the whole form.
glehmann
temporarily deployed
to
github-pages
September 1, 2026 16:59 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every line click re-centered the focused line, breaking double-click
word selection because the first click moved the content under the
cursor. Focus changes now carry their source; only keyboard and
programmatic focus keep the centering scroll, while mouse clicks
never move the viewport.
The inline comment form now scrolls itself fully into view on open
with the smallest possible scroll, so clicking a line near the
viewport bottom still shows the whole form.