Conversation
char0n
reviewed
Sep 17, 2025
char0n
approved these changes
Sep 17, 2025
Member
char0n
left a comment
char0n
left a comment
There was a problem hiding this comment.
I usually try to avoid common or lib packages, but I understand the motivation. Could we rename it to commons though?
Left one review comment directly in code as well.
frantuma
force-pushed
the
feat/common-shared-code
branch
from
4f5e98e to
9a6cd35
Compare
frantuma
changed the title
jentic-openapi-common package with subprocess utilityjentic-openapi-common package with subprocess utility
…n` package with subprocess utility Add new `jentic-openapi-common` package containing shared utilities for OpenAPI-related operations: - Implement `run_checked` subprocess utility with enhanced error handling. - Add `SubprocessExecutionError` to handle non-zero exit codes. - Include type-checking support with `py.typed`. - Update workspace and CI configurations to include `jentic-openapi-common`. - Replace direct `subprocess.run` calls with `run_checked` in `spectral_validator.py` for improved error handling and result encapsulation. This package provides reusable functionality for subprocess management, aiding other OpenAPI tools in the monorepo.
frantuma
force-pushed
the
feat/common-shared-code
branch
from
9a6cd35 to
7065bf6
Compare
Collaborator
Author
|
@char0n (sorry did a refactor without remembering I asked a review..) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new
jentic-openapi-commonpackage containing shared utilities for OpenAPI-related operations:run_checkedsubprocess utility with enhanced error handling.SubprocessExecutionErrorto handle non-zero exit codes.py.typed.jentic-openapi-common.subprocess.runcalls withrun_checkedinspectral_validator.pyfor improved error handling and result encapsulation.This package provides reusable functionality for subprocess management, aiding other OpenAPI tools in the monorepo.