feat(skills): add P2 skills completing the full lifecycle#10
Conversation
Add 18 P2 skills completing end-to-end coverage: analyze-competitors, create-roadmap, create-metrics-framework, create-shape-up-pitch, create-threat-model (STRIDE), create-feature-flag-plan, audit-accessibility (WCAG 2.1 AA), audit-performance (Core Web Vitals), create-gtm-brief, synthesize-feedback, analyze-metrics, create-experiment-design (A/B testing), create-decision-log, validate-skill-coverage, plus stack-specific performance and testing skills.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the available skills by introducing 18 new P2-level capabilities. These additions aim to provide comprehensive coverage across the entire product development lifecycle, from initial product strategy and competitive analysis to security, performance optimization, and robust experimentation. The new skills also include specialized guidance for modern development stacks like React, Next.js, Flutter, and Python testing, ensuring a broader and deeper set of tools for various engineering and product challenges. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces 18 new P2 skills, significantly expanding coverage across the entire product development lifecycle, from strategy and design to performance and security. The new skills are well-documented, follow a consistent structure, and provide clear workflows and valuable anti-patterns.
My review found the skill definitions to be of high quality. I have one suggestion for improvement in skills/python-testing-patterns/SKILL.md to provide more accurate guidance regarding pytest's assertion capabilities.
A critical omission in this PR is the update to skills/skills-index.yaml. According to CONTRIBUTING.md, this file must be updated when adding new skills to make them discoverable. Without this change, the 18 new skills will not be registered. Please add all new skills to the index file before merging.
Note: Security Review has been skipped due to the limited scope of the PR.
1 participant
Summary
Skills Added
analyze-competitorscreate-roadmapcreate-metrics-frameworkcreate-shape-up-pitchcreate-threat-modelcreate-feature-flag-planaudit-accessibilityaudit-performancecreate-gtm-briefsynthesize-feedbackanalyze-metricscreate-experiment-designcreate-decision-logvalidate-skill-coveragereact-performance-auditnextjs-performanceflutter-platform-patternspython-testing-patternsTest plan
scripts/validate-skills.shpasses