Skip to content

feat(skills): add fix-findings skill, move outputs to .chalk/#12

Merged
breadoncee merged 2 commits into
mainfrom
feat/review-pipeline-v2
Mar 10, 2026
Merged

feat(skills): add fix-findings skill, move outputs to .chalk/#12
breadoncee merged 2 commits into
mainfrom
feat/review-pipeline-v2

Conversation

@breadoncee

Copy link
Copy Markdown
Collaborator

Summary

  • Adds fix-findings skill: provider-agnostic — discovers *.findings.md files dynamically via glob instead of hardcoding provider names. Reads findings from any reviewer, applies fixes by priority with user confirmation, and updates the resolution log.
  • Moves all review pipeline outputs from .reviews/ to .chalk/reviews/ across create-handoff, create-review, and fix-findings for consistency with the .chalk directory convention.

Test plan

  • Run scripts/validate-skills.sh — all 11 skills pass
  • Test fix-findings with findings from different reviewer names (not just codex/gemini)
  • Test fix-findings codex for single-reviewer mode
  • Verify create-handoff writes to .chalk/reviews/{session}/handoff.md
  • Verify create-review bootstraps scripts into .chalk/reviews/

- Add fix-findings: provider-agnostic skill that reads *.findings.md
  files from any reviewer, applies fixes by priority with user
  confirmation, and updates the resolution log
- Move all review pipeline outputs from .reviews/ to .chalk/reviews/
  for consistency with the .chalk directory convention
- fix-findings discovers reviewers dynamically via glob instead of
  hardcoding provider names
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to the project's review automation capabilities by adding a new skill designed to automatically address code review findings. Concurrently, it standardizes the storage location for all review-related artifacts, consolidating them into a dedicated .chalk/reviews/ directory. This refactoring improves the organization and maintainability of the review pipeline's output and internal tooling.

Highlights

  • New Skill: fix-findings: Introduced a new fix-findings skill that automates the process of applying code review findings. This skill is provider-agnostic, dynamically discovers *.findings.md files, applies fixes by priority with user confirmation, and updates a resolution log.
  • Directory Structure Refactor: Migrated all review pipeline output files and related scripts from the .reviews/ directory to a new .chalk/reviews/ directory. This change ensures consistency with the .chalk directory convention across create-handoff, create-review, and the new fix-findings skills.
  • Dynamic Findings Discovery: The fix-findings skill now discovers findings files dynamically via glob patterns (e.g., *.findings.md), removing the need to hardcode specific reviewer names.
Changelog
  • skills/create-handoff/SKILL.md
    • Updated the SESSION_DIR variable to point to the new .chalk/reviews/ path.
  • skills/create-review/SKILL.md
    • Modified all references to the .reviews/ directory to use .chalk/reviews/ for session detection, script bootstrapping, output paths, and template creation.
    • Updated paths for making scripts executable and saving the current session.
  • skills/fix-findings/SKILL.md
    • Added a new skill definition for fix-findings, outlining its process for resolving active sessions, parsing findings, presenting them for user confirmation, applying fixes, and updating a resolution log.
  • skills/skills-index.yaml
    • Registered the newly added fix-findings skill in the central skills index.
Activity
  • The pull request was created by breadoncee to introduce a new skill for fixing findings and to refactor the directory structure for review outputs.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new fix-findings skill and updates existing skills (create-handoff, create-review) to use the .chalk/reviews/ directory for consistency, aligning with the .chalk/ convention. However, the new fix-findings skill has significant security vulnerabilities, including potential command injection in session discovery and path traversal when handling files, due to treating untrusted data as trusted. Additionally, the skill's logic for parsing, deduplicating, and applying fixes requires more precise definition to ensure correctness and robustness.

Comment thread skills/fix-findings/SKILL.md Outdated
Comment thread skills/fix-findings/SKILL.md
Comment thread skills/fix-findings/SKILL.md Outdated
Comment thread skills/fix-findings/SKILL.md Outdated
Comment thread skills/fix-findings/SKILL.md Outdated
Comment thread skills/fix-findings/SKILL.md
Comment thread skills/fix-findings/SKILL.md Outdated
- Use Glob tool instead of shell ls for findings discovery (security)
- Add path validation rule to reject paths outside the repo (security)
- Define explicit dedup criteria: same file + nearby lines + similar category
- Clarify context reading: 30 lines of surrounding context minimum
- Replace ambiguous conflict resolution with user-choice approach
- Simplify P3 triviality check to single-line/obvious one-liner
@breadoncee
breadoncee merged commit 9727236 into main Mar 10, 2026
1 check passed
@breadoncee
breadoncee deleted the feat/review-pipeline-v2 branch March 10, 2026 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant