feat(skills): add fix-findings skill, move outputs to .chalk/#12
Conversation
- Add fix-findings: provider-agnostic skill that reads *.findings.md files from any reviewer, applies fixes by priority with user confirmation, and updates the resolution log - Move all review pipeline outputs from .reviews/ to .chalk/reviews/ for consistency with the .chalk directory convention - fix-findings discovers reviewers dynamically via glob instead of hardcoding provider names
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement to the project's review automation capabilities by adding a new skill designed to automatically address code review findings. Concurrently, it standardizes the storage location for all review-related artifacts, consolidating them into a dedicated Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new fix-findings skill and updates existing skills (create-handoff, create-review) to use the .chalk/reviews/ directory for consistency, aligning with the .chalk/ convention. However, the new fix-findings skill has significant security vulnerabilities, including potential command injection in session discovery and path traversal when handling files, due to treating untrusted data as trusted. Additionally, the skill's logic for parsing, deduplicating, and applying fixes requires more precise definition to ensure correctness and robustness.
- Use Glob tool instead of shell ls for findings discovery (security) - Add path validation rule to reject paths outside the repo (security) - Define explicit dedup criteria: same file + nearby lines + similar category - Clarify context reading: 30 lines of surrounding context minimum - Replace ambiguous conflict resolution with user-choice approach - Simplify P3 triviality check to single-line/obvious one-liner
Summary
*.findings.mdfiles dynamically via glob instead of hardcoding provider names. Reads findings from any reviewer, applies fixes by priority with user confirmation, and updates the resolution log..reviews/to.chalk/reviews/acrosscreate-handoff,create-review, andfix-findingsfor consistency with the.chalkdirectory convention.Test plan
scripts/validate-skills.sh— all 11 skills passfix-findingswith findings from different reviewer names (not just codex/gemini)fix-findings codexfor single-reviewer modecreate-handoffwrites to.chalk/reviews/{session}/handoff.mdcreate-reviewbootstraps scripts into.chalk/reviews/