PR Process

PR Process

All plugin and skill submissions go through code review before merging. This page covers what reviewers check, the review timeline, and how to get your PR merged.

---

What Reviewers Check

Every pull request is evaluated across six dimensions:

Area	What We Look For
Functionality	Does the plugin work as described? All commands, hooks, and agents behave correctly.
Code quality	Clean, well-organized code. Proper error handling. No warnings. See Quality Standards.
Security	No hardcoded secrets or credentials. Inputs validated. Scoped Bash in allowed-tools. Principle of least privilege.
Documentation	Comprehensive README with installation steps, usage examples, and requirements. Accurate and up to date.
Testing	Plugin has been tested locally. Commands produce expected output. Edge cases considered.
Style	Follows project conventions for Markdown, JSON, and Bash. Kebab-case naming. Proper file permissions.

---

CI Checks

Before a reviewer looks at your PR, automated checks must pass. The CI/CD Pipeline runs five parallel jobs on every PR:

Job	What It Validates
validate	JSON validity, plugin structure, catalog sync, secret scanning, dangerous patterns
test	MCP plugin builds, vitest, Python pytest, ccpi validate --strict, frontmatter
check-package-manager	Enforces pnpm/npm policy per directory
marketplace-validation	Astro build, route validation, link validation, smoke tests, cowork security
playwright-tests	E2E tests on chromium, webkit, and mobile

All CI checks must pass before your PR will be reviewed. If a check fails, inspect the CI output, fix the issue, and push an update to your branch.

---

Review Timeline

Phase	Timeframe
Initial review	Within 7 days of submission
Feedback provided	Within 14 days
Merge after approval	1-3 days

Complex plugins or those requiring multiple revision rounds may take longer.

---

Addressing Feedback

When a reviewer requests changes:

1. Read all comments carefully and address each one.
2. Make changes in your branch and push updates.
3. Reply to review comments explaining what you changed.
4. Request a re-review when all feedback has been addressed.

Do not force-push over review history. Add new commits so reviewers can see what changed between rounds.

---

Merge Requirements

A PR is ready to merge when:

• All CI checks pass (green)
• At least one maintainer has approved the review
• All reviewer feedback has been addressed
• The branch is up-to-date with main

After approval, a maintainer will merge your PR within 1-3 days.

---

Tips for a Smooth Review

• Run validation before submitting. Use pnpm run sync-marketplace and ./scripts/validate-all-plugins.sh locally.
• Keep PRs focused. One plugin per PR. Avoid mixing unrelated changes.
• Write clear commit messages. Describe what and why, not just how.
• Use the PR template. It ensures you provide all the information reviewers need.
• Check the Quality Standards page. Meeting those standards up front reduces review rounds.

---

See also: Contributing | Quality Standards | CI/CD Pipeline