[renovate-bot] - Update dependency use-sound to v5 #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
|
|
renovate
bot
force-pushed
the
renovate/use-sound-5.x
branch
from
ef9a512 to
8abf751
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
4.0.4->5.0.0Release Notes
joshwcomeau/use-sound (use-sound)
v5.0.0Compare Source
Fix bug with sprites and
playbackRateWhen using sprites, the library would crash when either the volume or playbackRate changed. In development, it would also crash during hot reload.
I spent about half an hour digging into this, and wasn’t really able to find a proper fix. The band-aid I came up with is to ignore changes to
playbackRatewhen sprites are used. This means that if you have a dynamic playbackRate in your application, you can no longer use sprites, and will need a separateuseSoundinstance for each sound effect.The problematic line in question is this: https://github.com/goldfire/howler.js/blob/master/src/howler.core.js#L1564. From what I can tell,
sound._spriteresolves to_defaultinstead of the actual names of our sprites, which causes an exception. If anyone feels like digging into this and comes up with a fix, please let me know by email at [email protected].Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.