Skip to content

feat: add client support for dungeon entrance rando#46

Open
keraion wants to merge 2 commits into
jeromkiller:Harkipellagofrom
keraion:archi/ap-dungeon-entrance-shuffle
Open

feat: add client support for dungeon entrance rando#46
keraion wants to merge 2 commits into
jeromkiller:Harkipellagofrom
keraion:archi/ap-dungeon-entrance-shuffle

Conversation

@keraion

@keraion keraion commented Jul 4, 2026

Copy link
Copy Markdown

This adds the client side work for supporting dungeon entrance randomizer. This looks to reflect the dungeon shuffle in the native randomizer. This is also set up to be backwards compatible with a default of off if the server doesn't send a value for shuffling.

AP world side work to follow

Build Artifacts

@jeromkiller

Copy link
Copy Markdown
Owner

Thanks for the contributions, I'll have a look at this as well as your other PR's when I have time.

You should probably check in with @mattman107. I believe he's also been working on entrance randomization for archipelago. you might want to compare notes and make sure you're not doing double work

@keraion

keraion commented Jul 4, 2026

Copy link
Copy Markdown
Author

Sure and thanks for doing so much work behind this! I took a look at the closed PR 19 on the apworld side to see how this and my other PR lined up, but happy to reach out to compare notes.

@mattman107

mattman107 commented Jul 4, 2026

Copy link
Copy Markdown

I kinda wanted to keep it on the down low for a couple of reasons, but the big one is because I was using Claude Code to help me out. I was planning on finishing it up this weekend and showing @jeromkiller in private to discuss (already has boss, dungeon, overworld, grotto, interior, decoupled, mixed). It is dense to say the least. Lots of stuff going on.

My previous attempt you referenced HarbourMasters/Archipelago-SoH#19 had some pretty major flaws that needed ironing out. I was having to fight the GER to work, and Ships entrance graph just wasn't working out super well with it.

My new attempt is closer to a port of Ships ER.

@keraion

keraion commented Jul 4, 2026

Copy link
Copy Markdown
Author

@mattman107 that's awesome! I'm also happy to help review. If there is anything I can help with there I'm good to collaborate. I have a bit more time lately to work on some projects.

@mattman107

Copy link
Copy Markdown

Sounds good to me. I'm totally down to collab. I'm still hesitant to make a PR here as I would like some more validation and stuff done away from prying eyes, but if you check out my client and world forks (probably tomorrow) there should be branches with my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants