Skip to content

Add update strategy deployment#1646

Merged
jertel merged 9 commits intojertel:masterfrom
efazenda:add_update_strategy_deployment
Apr 3, 2025
Merged

Add update strategy deployment#1646
jertel merged 9 commits intojertel:masterfrom
efazenda:add_update_strategy_deployment

Conversation

@efazenda
Copy link
Copy Markdown
Contributor

@efazenda efazenda commented Mar 10, 2025

Description

Dear all,

This is a PR for addind support of update strategy in the deployment of the ElastAlert2 Helm Chart.

Have a nice day and thanks for ElastAlert2 tool !

Best Regards, Edouard Fazenda.

Checklist

  • [x ] I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

efazenda and others added 6 commits March 10, 2025 16:02
Update deployment.yaml template file to add update.strategey support.
Add default values in the values.yaml file for update strategy.
@jertel
Copy link
Copy Markdown
Owner

jertel commented Mar 11, 2025

Thanks for the submission. This needs a CHANGELOG.md entry and then should be ready to go.

@efazenda
Copy link
Copy Markdown
Contributor Author

Dear @jertel

Thanks for accepting the change !

Do i have to decide a new release version and add the PR on the description om CHANGELOG.md ?

Best Regards, Edouard Fazenda.

@jertel
Copy link
Copy Markdown
Owner

jertel commented Mar 12, 2025

You can add the changelog entry under the New Features section at the top of the file. It needs to follow the same format as the others. That's it.

@nsano-rururu
Copy link
Copy Markdown
Collaborator

@jertel

I think it would be best to fix the CHANGLOG, merge and incorporate it, and release the next version.
Good pull requests should be incorporated, and if there is no reply, shouldn't it be okay to just follow and incorporate them?

@nsano-rururu
Copy link
Copy Markdown
Collaborator

I think there may be reasons why they can't reply, such as being busy at work.

@nsano-rururu
Copy link
Copy Markdown
Collaborator

It should be incorporated since it was a pull request.

This is just my personal opinion.

@efazenda
Copy link
Copy Markdown
Contributor Author

efazenda commented Apr 3, 2025

Dear all,

Sorry for the delay, thanks for the reminder :)

Have all a nice day !

@jertel jertel merged commit b317111 into jertel:master Apr 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants