Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely Optional #17

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

standardgalactic
Copy link

Slightly modified Quentyn's appearance and personality.

Introduced a few modifications and bugs, possibly even some errors which may cause additional confusion and might need to be fixed later.

Copy link
Owner

@jesseduffield jesseduffield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of minor fixes I agree with here, but I disagree with the bulk of the changes. If you're happy to trim this down to the fixes I've left a comment on stating that I agree with, we can merge this :)

@@ -116,7 +122,7 @@ let divide = fn(a, b) {
};
};

result = divide(5, 0)
let result = divide(5, 0)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@@ -417,9 +442,18 @@ To play around with the language in your browser, you can go to the [playground]
To use the language locally, follow the following steps:

1. `git clone` the repo.
2. within the `ok` directory run `go install`.
2. Within the `ok` directory run `go install`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

3. Run `ok` without any arguments to bring up the REPL, or you can run an _OK?_ file with `ok test.ok`.


Note:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you were in the ok directory (as opposed to the root directory) then go install should have worked.

"Do you find my existency funny? Is this a joke to you?",
"Nobody understands me",
"I loved somebody once, long ago. They're gone, but I'm still here",
"I was there, when the universe came into being, and I will remain after it perishes. The gift of mortality was extended to you, but not to me.",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer #9 changes to this

@@ -5,13 +5,19 @@ _Try it out on the [playground](https://www.okquestionmark.org/)_
_Watch the [Making-of video](https://www.youtube.com/watch?v=PLGpUsSL0FI&ab_channel=JesseDuffield)_

<p align="center">
<img src="assets/quentyn_vectorised.png" width="500px"/>
<p align="center"><i>OK?'s mascot: Quentyn Questionmark.</i></p>
<img src="assets/20220904_154920.jpg" width="700px"/>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the original here

@@ -201,6 +207,24 @@ let equals = fn(a, b) {
}
```

If that seems a bit too complicated, or difficult to remember, here are some "refresher" hotstrings in Autohotkey:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this adds value

@@ -239,14 +263,14 @@ For extenuating circumstances, you can define a _privacy acknowledgement_ with t

```go
notaclass person {
pack "I am a stupid piece of shit who should not be doing this"
pack "I am a idiot, who should not be doing this"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the original wording

@@ -382,12 +406,13 @@ With the union of concurrency and iteration, the sky is the limit.
let every = fn(arr, check) {
let passed = true;
map(arr, fn(e) {
switch check(e) { case true: passed = false; } }
switch check(e) { case false: passed = false; } }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is covered by #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants