Skip to content

Fix ssh context not working #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

peauc
Copy link
Contributor

@peauc peauc commented Sep 2, 2024

Fix issue as described in #559

@peauc
Copy link
Contributor Author

peauc commented Sep 2, 2024

It seems that I was missing the code of the PR #511 that was merged early June.
I still have the issue using my now fresh copy of master.

The code of this branch is a bit cleaner and now works for me

@peauc
Copy link
Contributor Author

peauc commented Sep 3, 2024

I'll get to the tests in a few days.

Copy link
Owner

@jesseduffield jesseduffield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments :)

client.FromEnv,
client.WithVersion(APIVersion),
}
// For an ssh connection the DOCKER_HOST env variable has been overridden.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain the rationale behind these changes? I'm not clear on the reasoning

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just wired it correctly for the SSH connection to work.
I'll rework it so its clearer and doesn't rely on a modified docker host env variable.

Copy link
Contributor Author

@peauc peauc May 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jesseduffield took over 6 months to get some free time but now that I'm in vacation... :D

The rationale is that ATM ssh tunneling with docker context over lazydocker is broken. There are a few issues regarding this see this link
In my opinion those issues are due to an edge case in the current implementation of the ssh tunneling & docker host parsing.
I've rewritten a few parts to both make it simpler and more robust, tell me what you think :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants