-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix ssh context not working #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
It seems that I was missing the code of the PR #511 that was merged early June. The code of this branch is a bit cleaner and now works for me |
I'll get to the tests in a few days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments :)
pkg/commands/docker.go
Outdated
client.FromEnv, | ||
client.WithVersion(APIVersion), | ||
} | ||
// For an ssh connection the DOCKER_HOST env variable has been overridden. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain the rationale behind these changes? I'm not clear on the reasoning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wired it correctly for the SSH connection to work.
I'll rework it so its clearer and doesn't rely on a modified docker host env variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jesseduffield took over 6 months to get some free time but now that I'm in vacation... :D
The rationale is that ATM ssh tunneling with docker context over lazydocker is broken. There are a few issues regarding this see this link
In my opinion those issues are due to an edge case in the current implementation of the ssh tunneling & docker host parsing.
I've rewritten a few parts to both make it simpler and more robust, tell me what you think :)
Fix issue as described in #559