Fix ssh context not working #577
Conversation
|
It seems that I was missing the code of the PR #511 that was merged early June. The code of this branch is a bit cleaner and now works for me |
|
I'll get to the tests in a few days. |
pkg/commands/docker.go
Outdated
| client.FromEnv, | ||
| client.WithVersion(APIVersion), | ||
| } | ||
| // For an ssh connection the DOCKER_HOST env variable has been overridden. |
There was a problem hiding this comment.
Could you explain the rationale behind these changes? I'm not clear on the reasoning
There was a problem hiding this comment.
I just wired it correctly for the SSH connection to work.
I'll rework it so its clearer and doesn't rely on a modified docker host env variable.
There was a problem hiding this comment.
Hey @jesseduffield took over 6 months to get some free time but now that I'm in vacation... :D
The rationale is that ATM ssh tunneling with docker context over lazydocker is broken. There are a few issues regarding this see this link
In my opinion those issues are due to an edge case in the current implementation of the ssh tunneling & docker host parsing.
I've rewritten a few parts to both make it simpler and more robust, tell me what you think :)
Fix issue as described in #559