Skip to content

Conversation

@jesseduffield
Copy link
Owner

@jesseduffield jesseduffield commented Sep 25, 2022

  • PR Description

Based on #1555

This adds support for the gh binary: allowing the user to configure for gh to be used and for PR numbers to be displayed next to branches.

Another thing that we should investigate is what's involved with using the gh code directly as a package compared to shelling out to the binary, given that gh is written in Go.

From the original PR:

Something we'll want to do before merging this PR is moving the logic from GetRepoInfoFromURL into pkg/commands/hosting_service/hosting_service.go so that we're containing all of our hosting service specific code in the one place (and it will make it easier to support PR numbers for other hosting services down the line).

There's a couple more things that would be good (not necessary for merging the PR):

support for branches whose UpstreamRemote is of the form 'git@.../lazygit.go'. These don't actually have a remote to match on locally, but they do contain the owner name in the URL
structuring the code to support other PR structures e.g. not every hosting service has an owner/branch structure: azure has org/project/branch.

  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go run scripts/cheatsheet/main.go generate)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@jesseduffield
Copy link
Owner Author

Closing in favour of #2781

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants