Skip to content

Fix truncation of branches when scrolling branches panel to the left #4483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stefanhaller
Copy link
Collaborator

  • PR Description

Truncation of long branch names didn't take the horizontal scroll position into account; when scrolling the panel to the left using H, the long names were truncated way before the right edge of the view.

  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@stefanhaller stefanhaller added the bug Something isn't working label Apr 13, 2025
Copy link

codacy-production bot commented Apr 13, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for d68c1161 25.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d68c116) Report Missing Report Missing Report Missing
Head commit (edc3b57) 54452 47226 86.73%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4483) 4 1 25.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

…o the left

When scrolling the view to the left, the available width becomes the width of
the view plus the scroll position.
If the context says it wants to rerender when its width changes, we must also
rerender when the horizontal scroll position changes.
@stefanhaller stefanhaller force-pushed the fix-horizontal-scrolling-of-branches-panel branch from 1967e48 to edc3b57 Compare April 13, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant