Fix window arrangement when a popup or the search prompt is open

[stefanhaller]

When focusing the main view, going into full screen mode by pressing '+' twice, and then opening the search prompt ('/') or a menu (e.g. '?' or ':'), the full screen display would switch to the focused side panel.

Fix this by always excluding popups from the window arrangement logic. No popup should ever have any influence on how the views beneath it are laid out.

Addresses this detail aspect of #1113.

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for 442ede91	✅ 100.00%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (442ede9)	Report Missing	Report Missing	Report Missing
Head commit (8eeb16c)	58435	50823	86.97%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#4961)	15	15	100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩