chore: ensure types are available for semver
#1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why did it automerge with failing CI 🤔 |
|
I don't know - it's done that before; my first guess would be that the branching rules are not setup to block it's merging (sorry 😅) |
|
I tried enabling merge queue now, with mandatory status checks. let's see if that works 😀 |
|
#1715 enabled automerge and merge queue stuff, so 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently we were depending on this implicitly (which surprises me), and #1708 updated
conventional-changelog-writerto a version that no longer has this as a dependency, causing CI to fail in some cases because only some versions of@typescript-eslintdepend on them.