test: add e2e tests

[mrazauskas]

Resolves #18

@SimenB Here they are – e2e tests. The ideas / situations taken from readme.md. Do we need something more?

Interestingly TypeScript test does not need empty.d.ts. Did I misunderstood something?

The runJest is adapted from jest-runner-eslint.

[SimenB]

yay! I see there's no CI set up here - I can do that on master (and rename it to main)

[mrazauskas]

yay! I see there's no CI set up here - I can do that on master (and rename it to main)

Yes, please setup CI and then I will push changes. That would be the best.

[SimenB]

@mrazauskas just pushed it 🙂 I just added eslint, so you'll need a new job for Jest, but still

[mrazauskas]

Perfect! Will fix everything bit later.

[mrazauskas]

Done. I removed previous typescript test. Could not reproduce the situation mentioned in docs. I was looking at the linked issue too and was experimenting in different ways, but could not make it work as expected.

That’s some work around related with tsd and not this library. So I think it is fine to skip it for now.

By the way, empty.d.ts files are used in Jest type tests too. All is set up exactly how docs in this library expalin. Interestingly it seems like those empty.d.ts in Jest repo just do nothing. They can be removed and all works as expected. I will send a PR later. Just trying to explain the puzzle I was looking at.

[SimenB]

By the way, empty.d.ts files are used in Jest type tests too. All is set up exactly how docs in this library expalin. Interestingly it seems like those empty.d.ts in Jest repo just do nothing. They can be removed and all works as expected. I will send a PR later. Just trying to explain the puzzle I was looking at.

ah, nice! less random files is a good thing 🙂

[SimenB]

adding files breaks it :( shipping with e2e types suck tho. Lemme play with it

[SimenB]

@mrazauskas this is close! Tests fail on windows for some reason (we can skip it if it's an upstream issue rather than an issue with our code)

[mrazauskas]

These might be the roots of problems on Windows

jest-runner-tsd/src/run.js

Lines 24 to 25 in f0e14fb

	// Convert absolute path to relative path
	const testFile = testPath.replace(process.cwd() + '/', '');

jest-runner-tsd/src/run.js

Line 31 in f0e14fb

testFile.substring(0, testFile.lastIndexOf('/')),

I will try to fix. Thanks for setting up everything. Very useful.

[SimenB]

Good find! Should use path.sep and not hard code / probably? 🙂

[mrazauskas]

Looked through and removed everything what seemed suspicious. Let’s see if this helps.

[SimenB]

By the way, did you notice tsdjs/tsd#127? Would be really helpful to land this one.

Missed it, very exciting! Not needing the fork would be super awesome 👍

[mrazauskas]

Found it. testFiles must be an array of globs, but here a relative path was passed. On Windows this throws "Could not find test files". The glob did not match any files, because slashes were wrong.

[SimenB]

Closer! Seems we need to normalize the icons in the snapshot (https://github.com/facebook/jest/blob/7dd17d541bcdb4d17d96b53586949fb195294040/e2e/Utils.ts#L278-L287) and normalize the path printed by diagnostics. Jest already normalizes \ to / in paths on windows, so that would be consistent

[SimenB]

so close 😀

[SimenB]

Try to pass testFile here

jest-runner-tsd/src/run.js

Line 52 in f0e14fb

`${testFile}:${test.line}:${test.column} - ${test.severity} - ${test.message}`

though slash

[mrazauskas]

A.. Got it already. Just a minute (;

[SimenB]

🎉

[mrazauskas]

Yes! Thanks. It was fun.