Add type-only import test case for dependencyExtractor #15307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
CoryDanielson
commented
Sep 16, 2024
| import {type foo, typeof bar} from 'inv3'; | ||
| import { | ||
| type foo, | ||
| typeof bar, |
There was a problem hiding this comment.
note that this import ends with a , which is an interesting wrinkle to account for
- if all named exports are split by a comma, you can have a trailing item that is just space character(s)
|
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
|
Thanks for the PR! Happy to take an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #15308
This PR only adds a test case for an open bug report issue, so it can be referenced as a reproduction step.
Summary
I know the problem, but I don't know regex well enough to solve this problem. I could handle this with an if-statement in addDependency to exclude these deps, but I think regex is the proper solution given the rest of the code.
Test plan
Run this test to reproduce the bug.